From: "Paul E. McKenney" <paulmck@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, rostedt@goodmis.org,
Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>,
Nathan Chancellor <nathan@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Miguel Ojeda <ojeda@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Aaron Tomlin <atomlin@redhat.com>, Tejun Heo <tj@kernel.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH rcu 22/27] init: Remove "select SRCU"
Date: Mon, 9 Jan 2023 16:36:57 -0800 [thread overview]
Message-ID: <20230110003657.GE4028633@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <CAKwvOdmt7mnP_dfCMO_YUV792Zgtirk=NFqe8XH0z88-b0e23A@mail.gmail.com>
On Mon, Jan 09, 2023 at 04:02:48PM -0800, Nick Desaulniers wrote:
> On Wed, Jan 4, 2023 at 4:38 PM Paul E. McKenney <paulmck@kernel.org> wrote:
> >
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
>
> Looks like that's the case as of
> commit 0cd7e350abc4 ("rcu: Make SRCU mandatory")
> in v6.2-rc1.
I freely confess that I took the cowardly way out by making it
unconditional in the last merge window and getting rid of references in
the next merge window. ;-)
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Nick Desaulniers <ndesaulniers@google.com>
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > Cc: Vlastimil Babka <vbabka@suse.cz>
> > Cc: Nathan Chancellor <nathan@kernel.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Miguel Ojeda <ojeda@kernel.org>
> > Cc: Masami Hiramatsu <mhiramat@kernel.org>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Aaron Tomlin <atomlin@redhat.com>
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> Patch LGTM
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Thank you! I will apply this on my next rebase.
> Note that there's quite a few more of these though. Perhaps best to
> remove them all together? Or perhaps you already have individual
> patches out already for all of these?
I have these:
e73b36cbeb8eb arch/x86: Remove "select SRCU"
8bde7256e3bdc kvm: Remove "select SRCU"
047bbf23dd4f2 drivers/base: Remove CONFIG_SRCU
1b63789c861c1 drivers/clk: Remove "select SRCU"
3fe724041d29d drivers/cpufreq: Remove "select SRCU"
e8dc9f0f97d6f drivers/dax: Remove "select SRCU"
0be2fa022bcde drivers/devfreq: Remove "select SRCU"
e4ac435cd24da drivers/hwtracing/stm: Remove "select SRCU"
159ce13a6c500 drivers/md: Remove "select SRCU"
dbe417fa57042 drivers/net: Remove "select SRCU"
7cc598f342ae4 drivers/pci/controller: Remove "select SRCU"
fba630f40b15d fs/btrfs: Remove "select SRCU"
a17c8daaee218 fs/dlm: Remove "select SRCU"
fd77fd4fe1852 fs/notify: Remove "select SRCU"
47a84e7a9c1c6 fs/quota: Remove "select SRCU"
e5bc2dc08a416 init: Remove "select SRCU"
b7f8ff0898c04 kernel/power: Remove "select SRCU"
db389dace41db mm: Remove "select SRCU"
e5316ffd44aa1 fs: Remove CONFIG_SRCU
2d07d1c58fad7 kernel/notifier: Remove CONFIG_SRCU
c761c79f1e72f rcu: Remove CONFIG_SRCU
Plus there are three more that people wanted to take via their own
trees. And I am fine either way.
But as long as you generated the list...
> $ grep -rn 'select SRCU'
> mm/Kconfig:670: select SRCU
> kernel/power/Kconfig:121: select SRCU
> arch/mips/kvm/Kconfig:29: select SRCU
> arch/riscv/kvm/Kconfig:30: select SRCU
> arch/s390/kvm/Kconfig:34: select SRCU
> arch/powerpc/kvm/Kconfig:25: select SRCU
> arch/x86/kvm/Kconfig:49: select SRCU
> arch/x86/Kconfig:286: select SRCU
> arch/x86/Kconfig:1941: select SRCU
> arch/arm64/kvm/Kconfig:31: select SRCU
> init/Kconfig:1868: select SRCU
> security/tomoyo/Kconfig:9: select SRCU
> fs/btrfs/Kconfig:20: select SRCU
> fs/dlm/Kconfig:7: select SRCU
> fs/quota/Kconfig:9: select SRCU
> fs/notify/Kconfig:4: select SRCU
> drivers/md/Kconfig:9: select SRCU
> drivers/clk/Kconfig:26: select SRCU
> drivers/dax/Kconfig:4: select SRCU
> drivers/devfreq/Kconfig:4: select SRCU
> drivers/net/Kconfig:337: select SRCU
> drivers/hwtracing/stm/Kconfig:5: select SRCU
> drivers/cpufreq/Kconfig:6: select SRCU
> drivers/opp/Kconfig:4: select SRCU
And it does look like I missed security/tomoyo/Kconfig, so thank you
for checking! I have queued the patch.
The other one missing from -next is drivers/opp/Kconfig, which Viresh
said that he was taking.
There is no trace of CONFIG_SRCU in -next, which is the more worrying
one.
Thanx, Paul
> > ---
> > init/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/init/Kconfig b/init/Kconfig
> > index 7e5c3ddc341de..af511c726d695 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -1865,7 +1865,6 @@ config PERF_EVENTS
> > default y if PROFILING
> > depends on HAVE_PERF_EVENTS
> > select IRQ_WORK
> > - select SRCU
> > help
> > Enable kernel support for various performance events provided
> > by software and hardware.
> > --
> > 2.31.1.189.g2e36527f23
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
next prev parent reply other threads:[~2023-01-10 0:37 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 01/27] arch/x86: Remove "select SRCU" Paul E. McKenney
2023-01-09 17:43 ` Sean Christopherson
2023-01-09 19:22 ` Paul E. McKenney
2023-01-09 20:05 ` Paul E. McKenney
2023-01-10 19:55 ` Sean Christopherson
2023-01-12 0:05 ` Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 02/27] arch/arm64/kvm: " Paul E. McKenney
2023-01-05 9:38 ` Marc Zyngier
2023-01-05 15:42 ` Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 03/27] arch/mips/kvm: " Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 04/27] arch/powerpc/kvm: " Paul E. McKenney
2023-01-11 23:49 ` Michael Ellerman
2023-01-12 0:01 ` Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 05/27] arch/riscv/kvm: " Paul E. McKenney
2023-01-07 9:58 ` Anup Patel
2023-01-07 16:03 ` Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 06/27] arch/s390/kvm: " Paul E. McKenney
2023-01-05 8:06 ` Heiko Carstens
2023-01-05 15:30 ` Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 07/27] block: " Paul E. McKenney
2023-01-05 0:43 ` Jens Axboe
2023-01-05 8:05 ` Heiko Carstens
2023-01-05 15:33 ` Paul E. McKenney
2023-01-05 15:36 ` Jens Axboe
2023-01-05 15:48 ` Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 08/27] drivers/base: Remove CONFIG_SRCU Paul E. McKenney
2023-01-05 11:23 ` Greg Kroah-Hartman
2023-01-05 0:37 ` [PATCH rcu 09/27] drivers/clk: Remove "select SRCU" Paul E. McKenney
[not found] ` <c59b64de02161ceeed11b43230cd46d0.sboyd@kernel.org>
2023-01-11 19:50 ` Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 10/27] drivers/cpufreq: " Paul E. McKenney
2023-01-05 4:04 ` Viresh Kumar
2023-01-05 15:09 ` Rafael J. Wysocki
2023-01-05 15:51 ` Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 11/27] drivers/dax: " Paul E. McKenney
2023-01-05 16:48 ` Dan Williams
2023-01-05 17:35 ` Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 12/27] drivers/devfreq: " Paul E. McKenney
2023-01-10 13:07 ` Chanwoo Choi
2023-01-10 15:01 ` Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 13/27] drivers/hwtracing/stm: " Paul E. McKenney
2023-01-13 13:19 ` Alexander Shishkin
2023-01-05 0:38 ` [PATCH rcu 14/27] drivers/md: " Paul E. McKenney
2023-01-05 0:44 ` Song Liu
2023-01-05 0:38 ` [PATCH rcu 15/27] drivers/net: " Paul E. McKenney
2023-01-05 1:28 ` Jakub Kicinski
2023-01-05 0:38 ` [PATCH rcu 16/27] drivers/opp: " Paul E. McKenney
2023-01-05 4:06 ` Viresh Kumar
2023-01-05 4:50 ` Paul E. McKenney
2023-01-05 6:17 ` Viresh Kumar
2023-01-05 15:28 ` Paul E. McKenney
2023-01-05 0:38 ` [PATCH rcu 17/27] drivers/pci/controller: " Paul E. McKenney
2023-01-12 14:37 ` Lorenzo Pieralisi
2023-01-12 15:27 ` Paul E. McKenney
2023-01-05 0:38 ` [PATCH rcu 18/27] fs/btrfs: " Paul E. McKenney
2023-01-05 9:06 ` Qu Wenruo
2023-01-05 15:41 ` Paul E. McKenney
2023-01-05 15:45 ` David Sterba
2023-01-05 16:05 ` Paul E. McKenney
2023-01-05 0:38 ` [PATCH rcu 19/27] fs/dlm: " Paul E. McKenney
2023-01-05 0:38 ` [PATCH rcu 20/27] fs/notify: " Paul E. McKenney
2023-01-05 11:30 ` Jan Kara
2023-01-05 0:38 ` [PATCH rcu 21/27] fs/quota: " Paul E. McKenney
2023-01-05 11:30 ` Jan Kara
2023-01-05 15:45 ` Paul E. McKenney
2023-01-05 0:38 ` [PATCH rcu 22/27] init: " Paul E. McKenney
2023-01-10 0:02 ` Nick Desaulniers
2023-01-10 0:05 ` Nick Desaulniers
2023-01-10 0:36 ` Paul E. McKenney [this message]
2023-01-05 0:38 ` [PATCH rcu 23/27] kernel/power: " Paul E. McKenney
2023-01-05 15:08 ` Rafael J. Wysocki
2023-01-05 0:38 ` [PATCH rcu 24/27] mm: " Paul E. McKenney
2023-01-05 0:38 ` [PATCH rcu 25/27] fs: Remove CONFIG_SRCU Paul E. McKenney
2023-01-05 0:38 ` [PATCH rcu 26/27] kernel/notifier: " Paul E. McKenney
2023-01-05 0:38 ` [PATCH rcu 27/27] rcu: " Paul E. McKenney
2023-01-05 8:04 ` John Ogness
2023-01-05 15:23 ` Paul E. McKenney
2023-01-05 15:52 ` John Ogness
2023-01-05 16:04 ` Paul E. McKenney
2023-01-05 15:50 ` (subset) [PATCH rcu 0/27] Unconditionally enable SRCU Jens Axboe
2023-01-05 16:01 ` Paul E. McKenney
2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 01/20] arch/x86: Remove "select SRCU" Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 02/20] drivers/base: Remove CONFIG_SRCU Paul E. McKenney
2023-01-13 9:46 ` Rafael J. Wysocki
2023-01-13 0:11 ` [PATCH rcu v2 03/20] drivers/cpufreq: Remove "select SRCU" Paul E. McKenney
2023-01-20 16:54 ` Rafael J. Wysocki
2023-01-20 18:03 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 04/20] drivers/dax: " Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 05/20] drivers/hwtracing/stm: " Paul E. McKenney
2023-01-13 15:52 ` Alexander Shishkin
2023-01-13 19:47 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 06/20] drivers/md: " Paul E. McKenney
2023-01-17 23:08 ` Mike Snitzer
2023-01-18 3:55 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 07/20] drivers/net: " Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 08/20] drivers/pci/controller: " Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 09/20] fs: Remove CONFIG_SRCU Paul E. McKenney
2023-01-13 1:03 ` Jeff Layton
2023-01-13 1:10 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 10/20] fs/btrfs: Remove "select SRCU" Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 11/20] fs/dlm: " Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 12/20] fs/notify: " Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 13/20] fs/quota: " Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 14/20] init: " Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 15/20] kernel/notifier: Remove CONFIG_SRCU Paul E. McKenney
2023-01-13 11:25 ` Wysocki, Rafael J
2023-01-13 19:42 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 16/20] kernel/power: Remove "select SRCU" Paul E. McKenney
2023-01-20 16:55 ` Rafael J. Wysocki
2023-01-20 18:04 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 17/20] kvm: " Paul E. McKenney
2023-01-18 1:27 ` Sean Christopherson
2023-01-18 3:56 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 18/20] mm: " Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 19/20] tomoyo: " Paul E. McKenney
2023-01-13 14:22 ` Tetsuo Handa
2023-01-13 19:43 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 20/20] rcu: Remove CONFIG_SRCU Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 0/27] Unconditionally enable SRCU Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 1/4] arch/x86: Remove "select SRCU" Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 2/4] kvm: " Paul E. McKenney
2023-03-28 4:56 ` Sean Christopherson
2023-03-24 20:52 ` [PATCH rcu v3 3/4] mm: " Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 4/4] rcu: Remove CONFIG_SRCU Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110003657.GE4028633@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=atomlin@redhat.com \
--cc=christophe.leroy@csgroup.eu \
--cc=dmitry.torokhov@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mhiramat@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).