Hi Mercier",

Thank you for the patch! Yet something to improve:

[auto build test ERROR on b7bfaa761d760e72a969d116517eaa12e404c262]

url:    https://github.com/intel-lab-lkp/linux/commits/T-J-Mercier/memcg-Track-exported-dma-buffers/20230110-054247
base:   b7bfaa761d760e72a969d116517eaa12e404c262
patch link:    https://lore.kernel.org/r/20230109213809.418135-5-tjmercier%40google.com
patch subject: [PATCH 4/4] security: binder: Add transfer_charge SElinux hook
config: openrisc-randconfig-r004-20230109
compiler: or1k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/e412f67c5a40d34925284b62dde89448b8b7e208
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review T-J-Mercier/memcg-Track-exported-dma-buffers/20230110-054247
        git checkout e412f67c5a40d34925284b62dde89448b8b7e208
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/android/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/android/binder.c: In function 'binder_translate_fd':
>> drivers/android/binder.c:2282:21: error: implicit declaration of function 'security_binder_transfer_charge'; did you mean 'security_binder_transfer_file'? [-Werror=implicit-function-declaration]
    2282 |                 if (security_binder_transfer_charge(proc->cred, target_proc->cred)) {
         |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                     security_binder_transfer_file
   cc1: some warnings being treated as errors


vim +2282 drivers/android/binder.c

  2240	
  2241	static int binder_translate_fd(u32 fd, binder_size_t fd_offset, __u32 flags,
  2242				       struct binder_transaction *t,
  2243				       struct binder_thread *thread,
  2244				       struct binder_transaction *in_reply_to)
  2245	{
  2246		struct binder_proc *proc = thread->proc;
  2247		struct binder_proc *target_proc = t->to_proc;
  2248		struct binder_txn_fd_fixup *fixup;
  2249		struct file *file;
  2250		int ret = 0;
  2251		bool target_allows_fd;
  2252	
  2253		if (in_reply_to)
  2254			target_allows_fd = !!(in_reply_to->flags & TF_ACCEPT_FDS);
  2255		else
  2256			target_allows_fd = t->buffer->target_node->accept_fds;
  2257		if (!target_allows_fd) {
  2258			binder_user_error("%d:%d got %s with fd, %d, but target does not allow fds\n",
  2259					  proc->pid, thread->pid,
  2260					  in_reply_to ? "reply" : "transaction",
  2261					  fd);
  2262			ret = -EPERM;
  2263			goto err_fd_not_accepted;
  2264		}
  2265	
  2266		file = fget(fd);
  2267		if (!file) {
  2268			binder_user_error("%d:%d got transaction with invalid fd, %d\n",
  2269					  proc->pid, thread->pid, fd);
  2270			ret = -EBADF;
  2271			goto err_fget;
  2272		}
  2273		ret = security_binder_transfer_file(proc->cred, target_proc->cred, file);
  2274		if (ret < 0) {
  2275			ret = -EPERM;
  2276			goto err_security;
  2277		}
  2278	
  2279		if (IS_ENABLED(CONFIG_MEMCG) && (flags & BINDER_FD_FLAG_XFER_CHARGE)) {
  2280			struct dma_buf *dmabuf;
  2281	
> 2282			if (security_binder_transfer_charge(proc->cred, target_proc->cred)) {
  2283				ret = -EPERM;
  2284				goto err_security;
  2285			}
  2286	
  2287			if (unlikely(!is_dma_buf_file(file))) {
  2288				binder_user_error(
  2289					"%d:%d got transaction with XFER_CHARGE for non-dmabuf fd, %d\n",
  2290					proc->pid, thread->pid, fd);
  2291				ret = -EINVAL;
  2292				goto err_dmabuf;
  2293			}
  2294	
  2295			dmabuf = file->private_data;
  2296			ret = dma_buf_transfer_charge(dmabuf, target_proc->tsk);
  2297			if (ret) {
  2298				pr_warn("%d:%d Unable to transfer DMA-BUF fd charge to %d\n",
  2299					proc->pid, thread->pid, target_proc->pid);
  2300				goto err_xfer;
  2301			}
  2302		}
  2303	
  2304		/*
  2305		 * Add fixup record for this transaction. The allocation
  2306		 * of the fd in the target needs to be done from a
  2307		 * target thread.
  2308		 */
  2309		fixup = kzalloc(sizeof(*fixup), GFP_KERNEL);
  2310		if (!fixup) {
  2311			ret = -ENOMEM;
  2312			goto err_alloc;
  2313		}
  2314		fixup->file = file;
  2315		fixup->offset = fd_offset;
  2316		fixup->target_fd = -1;
  2317		trace_binder_transaction_fd_send(t, fd, fixup->offset);
  2318		list_add_tail(&fixup->fixup_entry, &t->fd_fixups);
  2319	
  2320		return ret;
  2321	
  2322	err_alloc:
  2323	err_xfer:
  2324	err_dmabuf:
  2325	err_security:
  2326		fput(file);
  2327	err_fget:
  2328	err_fd_not_accepted:
  2329		return ret;
  2330	}
  2331	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests