From: SeongJae Park <sj@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: SeongJae Park <sj@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Guenter Roeck <linux@roeck-us.net>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Arnd Bergmann <arnd@arndb.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Palmer Dabbelt <palmer@rivosinc.com>
Subject: Re: Linux 6.2-rc2
Date: Mon, 23 Jan 2023 18:27:32 +0000 [thread overview]
Message-ID: <20230123182732.188863-1-sj@kernel.org> (raw)
In-Reply-To: <CAK7LNATRpc3F6OKiRGsH0iLWRyykeoMy9EazPRPGWHH1T_2cUA@mail.gmail.com>
On Mon, 23 Jan 2023 18:09:27 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
> On Wed, Jan 11, 2023 at 4:14 AM SeongJae Park <sj@kernel.org> wrote:
> >
> > Hi Masahiro,
> >
> > On Wed, 11 Jan 2023 03:39:58 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > > On Tue, Jan 10, 2023 at 9:32 AM SeongJae Park <sj@kernel.org> wrote:
> > > >
> > > > On Tue, 3 Jan 2023 11:58:48 +0100 Ard Biesheuvel <ardb@kernel.org> wrote:
> > > >
> > > > > On Tue, 3 Jan 2023 at 03:13, Linus Torvalds
> > > > > <torvalds@linux-foundation.org> wrote:
> > > > > >
> > > > > > On Mon, Jan 2, 2023 at 5:45 PM Guenter Roeck <linux@roeck-us.net> wrote:
> > > > > > >
> > > > [...]
> > > > > --- a/include/asm-generic/vmlinux.lds.h
> > > > > +++ b/include/asm-generic/vmlinux.lds.h
> > > > > @@ -896,7 +896,7 @@
> > > > > * Otherwise, the type of .notes section would become PROGBITS
> > > > > instead of NOTES.
> > > > > */
> > > > > #define NOTES \
> > > > > - /DISCARD/ : { *(.note.GNU-stack) } \
> > > > > + .note.GNU-stack : { *(.note.GNU-stack) } \
> > > > > .notes : AT(ADDR(.notes) - LOAD_OFFSET) { \
> > > > > BOUNDED_SECTION_BY(.note.*, _notes) \
> > > > > } NOTES_HEADERS \
> > > > >
> > > > > The .note.GNU-stack has zero size, so the result should be the same.
> > > > >
> > > >
> > > > This also fixes ARCH=um build error on my system.
> > > >
> > > > Tested-by: SeongJae Park <sj@kernel.org>
> > >
> > >
> > >
> > > I am able to build ARCH=um defconfig at least.
> > >
> > > Can you provide the steps to reproduce the build error?
> >
> > I do the build for kunit test, like below.
> >
> > mkdir ../kunit.out
> > echo "
> > CONFIG_KUNIT=y
> >
> > CONFIG_DAMON=y
> > CONFIG_DAMON_KUNIT_TEST=y
> >
> > CONFIG_DAMON_VADDR=y
> > CONFIG_DAMON_VADDR_KUNIT_TEST=y
> >
> > CONFIG_DEBUG_FS=y
> > CONFIG_DAMON_DBGFS=y
> > CONFIG_DAMON_DBGFS_KUNIT_TEST=y
> > CONFIG_DAMON_PADDR=y" > ../kunit.out/.kunitconfig
> > ./tools/testsing/kunit/kunit.py run --build_dir ../kunit.out
> > [19:12:37] Configuring KUnit Kernel ...
> > [19:12:37] Building KUnit Kernel ...
> > Populating config with:
> > $ make ARCH=um O=../kunit.out/ olddefconfig
> > Building with:
> > $ make ARCH=um O=../kunit.out/ --jobs=36
> > ERROR:root:`.exit.text' referenced in section `.uml.exitcall.exit' of arch/um/drivers/virtio_uml.o: defined in discarded section `.exit.text' of arch/um/drivers/virtio_uml.o
> > collect2: error: ld returned 1 exit status
> > make[2]: *** [/home/sjpark/linux/scripts/Makefile.vmlinux:34: vmlinux] Error 1
> > make[1]: *** [/home/sjpark/linux/Makefile:1252: vmlinux] Error 2
> > make: *** [Makefile:242: __sub-make] Error 2
> >
> >
> > Thanks,
> > SJ
> >
>
>
> I did not see the error, though.
>
> The test seems to have succeeded.
>
>
>
>
> masahiro@zoe:~/ref/linux(master)$ cat ../kunit.out/.kunitconfig
> CONFIG_KUNIT=y
>
> CONFIG_DAMON=y
> CONFIG_DAMON_KUNIT_TEST=y
>
> CONFIG_DAMON_VADDR=y
> CONFIG_DAMON_VADDR_KUNIT_TEST=y
>
> CONFIG_DEBUG_FS=y
> CONFIG_DAMON_DBGFS=y
> CONFIG_DAMON_DBGFS_KUNIT_TEST=y
> CONFIG_DAMON_PADDR=y
> masahiro@zoe:~/ref/linux(master)$ ./tools/testing/kunit/kunit.py run
> --build_dir ../kunit.out
> [18:05:19] Configuring KUnit Kernel ...
> Regenerating .config ...
> Populating config with:
> $ make ARCH=um O=../kunit.out olddefconfig
> [18:05:22] Building KUnit Kernel ...
> Populating config with:
> $ make ARCH=um O=../kunit.out olddefconfig
> Building with:
> $ make ARCH=um O=../kunit.out --jobs=16
> [18:05:47] Starting KUnit Kernel (1/1)...
> [18:05:47] ============================================================
> [18:05:47] ==================== damon (9 subtests) ====================
> [18:05:47] [PASSED] damon_test_target
> [18:05:47] [PASSED] damon_test_regions
> [18:05:47] [PASSED] damon_test_aggregate
> [18:05:47] [PASSED] damon_test_split_at
> [18:05:47] [PASSED] damon_test_merge_two
> [18:05:47] [PASSED] damon_test_merge_regions_of
> [18:05:47] [PASSED] damon_test_split_regions_of
> [18:05:47] [PASSED] damon_test_ops_registration
> [18:05:47] [PASSED] damon_test_set_regions
> [18:05:47] ====================== [PASSED] damon ======================
> [18:05:47] ============== damon-operations (6 subtests) ===============
> [18:05:47] [PASSED] damon_test_three_regions_in_vmas
> [18:05:47] [PASSED] damon_test_apply_three_regions1
> [18:05:47] [PASSED] damon_test_apply_three_regions2
> [18:05:47] [PASSED] damon_test_apply_three_regions3
> [18:05:47] [PASSED] damon_test_apply_three_regions4
> [18:05:47] [PASSED] damon_test_split_evenly
> [18:05:47] ================ [PASSED] damon-operations =================
> [18:05:47] ================= damon-dbgfs (3 subtests) =================
> [18:05:47] [PASSED] damon_dbgfs_test_str_to_ints
> [18:05:47] [PASSED] damon_dbgfs_test_set_targets
> [18:05:47] [PASSED] damon_dbgfs_test_set_init_regions
> [18:05:47] =================== [PASSED] damon-dbgfs ===================
> [18:05:47] ============================================================
> [18:05:47] Testing complete. Ran 18 tests: passed: 18
> [18:05:47] Elapsed time: 28.194s total, 3.017s configuring, 25.058s
> building, 0.086s running
Thank you for sharing your results. I think it may depend on the compiler
version, because I use a quite old compiler.
$ gcc --version
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
Thanks,
SJ
[...]
next prev parent reply other threads:[~2023-01-23 18:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-01 22:01 Linux 6.2-rc2 Linus Torvalds
2023-01-02 10:20 ` Build regressions/improvements in v6.2-rc2 Geert Uytterhoeven
2023-01-02 22:56 ` Linux 6.2-rc2 Guenter Roeck
2023-01-03 0:21 ` Linus Torvalds
2023-01-03 1:45 ` Guenter Roeck
2023-01-03 2:13 ` Linus Torvalds
2023-01-03 3:57 ` Guenter Roeck
2023-01-03 4:26 ` Nathan Chancellor
2023-01-03 9:14 ` Thorsten Leemhuis
2023-01-03 10:58 ` Ard Biesheuvel
2023-01-03 11:45 ` Conor Dooley
2023-01-03 12:22 ` Guenter Roeck
2023-01-03 18:26 ` Nathan Chancellor
2023-01-03 18:34 ` Linus Torvalds
2023-01-05 13:44 ` Masahiro Yamada
2023-01-04 10:34 ` Michael Ellerman
2023-01-10 0:32 ` SeongJae Park
2023-01-10 18:39 ` Masahiro Yamada
2023-01-10 19:14 ` SeongJae Park
2023-01-23 9:09 ` Masahiro Yamada
2023-01-23 18:27 ` SeongJae Park [this message]
2023-02-06 22:56 ` SeongJae Park
2023-02-08 1:27 ` Masahiro Yamada
2023-01-13 14:59 ` Tom Saeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123182732.188863-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=masahiroy@kernel.org \
--cc=palmer@rivosinc.com \
--cc=torvalds@linux-foundation.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).