From: Li zeming <zeming@nfschina.com>
To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com
Cc: linux-kernel@vger.kernel.org, Li zeming <zeming@nfschina.com>
Subject: [PATCH v2] sched: rt: Simplify pick_next_rt_entity()
Date: Sat, 8 Apr 2023 02:09:52 +0800 [thread overview]
Message-ID: <20230407180952.2757-1-zeming@nfschina.com> (raw)
Remove useless intermediate variable "next" and its initialization.
Directly return the next RT scheduling entity obtained from
list_entry().
Signed-off-by: Li zeming <zeming@nfschina.com>
Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
---
v2: Simplify title and descriptive information.
kernel/sched/rt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 0a11f44adee5..e9b1c08c20a7 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1769,7 +1769,6 @@ static inline void set_next_task_rt(struct rq *rq, struct task_struct *p, bool f
static struct sched_rt_entity *pick_next_rt_entity(struct rt_rq *rt_rq)
{
struct rt_prio_array *array = &rt_rq->active;
- struct sched_rt_entity *next = NULL;
struct list_head *queue;
int idx;
@@ -1779,9 +1778,8 @@ static struct sched_rt_entity *pick_next_rt_entity(struct rt_rq *rt_rq)
queue = array->queue + idx;
if (SCHED_WARN_ON(list_empty(queue)))
return NULL;
- next = list_entry(queue->next, struct sched_rt_entity, run_list);
- return next;
+ return list_entry(queue->next, struct sched_rt_entity, run_list);
}
static struct task_struct *_pick_next_task_rt(struct rq *rq)
--
2.18.2
reply other threads:[~2023-04-06 1:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230407180952.2757-1-zeming@nfschina.com \
--to=zeming@nfschina.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).