From: Phil Auld <pauld@redhat.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and()
Date: Tue, 13 Jun 2023 09:16:51 -0400 [thread overview]
Message-ID: <20230613131651.GA536267@lorien.usersys.redhat.com> (raw)
In-Reply-To: <7bfde912-1e15-ec1f-8a62-9cc508739cd6@huawei.com>
On Tue, Jun 13, 2023 at 08:19:22PM +0800 Miaohe Lin wrote:
> On 2023/5/22 19:56, Miaohe Lin wrote:
> > cpumask_weight_and() can be used to count of bits both in rd->span and
> > cpu_active_mask. No functional change intended.
> >
> > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>
> friendly ping... :)
This looks reasonable, and better, to me.
Reviewed-by: Phil Auld <pauld@redhat.com>
>
> > ---
> > kernel/sched/deadline.c | 11 +----------
> > 1 file changed, 1 insertion(+), 10 deletions(-)
> >
> > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> > index 166c3e6eae61..fe983ed7bb12 100644
> > --- a/kernel/sched/deadline.c
> > +++ b/kernel/sched/deadline.c
> > @@ -110,20 +110,11 @@ static inline struct dl_bw *dl_bw_of(int i)
> > static inline int dl_bw_cpus(int i)
> > {
> > struct root_domain *rd = cpu_rq(i)->rd;
> > - int cpus;
> >
> > RCU_LOCKDEP_WARN(!rcu_read_lock_sched_held(),
> > "sched RCU must be held");
> >
> > - if (cpumask_subset(rd->span, cpu_active_mask))
> > - return cpumask_weight(rd->span);
> > -
> > - cpus = 0;
> > -
> > - for_each_cpu_and(i, rd->span, cpu_active_mask)
> > - cpus++;
> > -
> > - return cpus;
> > + return cpumask_weight_and(rd->span, cpu_active_mask);
> > }
> >
> > static inline unsigned long __dl_bw_capacity(const struct cpumask *mask)
> >
>
--
next prev parent reply other threads:[~2023-06-13 13:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 11:56 [PATCH] sched/deadline: simplify dl_bw_cpus() using cpumask_weight_and() Miaohe Lin
2023-05-22 10:47 ` Mukesh Ojha
2023-05-22 16:58 ` Dietmar Eggemann
2023-05-24 10:59 ` Valentin Schneider
2023-05-25 9:56 ` Daniel Bristot de Oliveira
2023-06-13 12:19 ` Miaohe Lin
2023-06-13 13:16 ` Phil Auld [this message]
2023-06-14 1:43 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613131651.GA536267@lorien.usersys.redhat.com \
--to=pauld@redhat.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).