From: Tom Rini <trini@konsulko.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-kernel@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH RESEND] get_maintainer: add email addresses from dts files
Date: Sat, 28 Oct 2023 13:46:56 -0400 [thread overview]
Message-ID: <20231028174656.GA3310672@bill-the-cat> (raw)
In-Reply-To: <829b122da52482707b783dc3d93d3ff0179cb0ca.camel@perches.com>
On Sun, Feb 12, 2023 at 01:17:45PM -0800, Joe Perches wrote:
> From: Shawn Guo <shawnguo@kernel.org>
>
> MAINTAINER file will get bloated quickly if individual section entry
> is created for each .dts/.dtsi file. Add the email address from dts
> files to get_maintainer output for saving unnecessary patching on
> MAINTAINER file.
>
> Suggested-by: Joe Perches <joe@perches.com>
> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Joe Perches <joe@perches.com>
> ---
>
> Hey Andrew. This was originally sent a year and a half ago.
>
> Link: https://lore.kernel.org/all/20210809080204.8381-1-shawnguo@kernel.org/
>
> Please pick this up. Thanks.
>
> scripts/get_maintainer.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 2075db0c08b8..15aa8f947f4b 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -436,7 +436,7 @@ sub maintainers_in_file {
>
> return if ($file =~ m@\bMAINTAINERS$@);
>
> - if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) {
> + if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) {
> open(my $f, '<', $file)
> or die "$P: Can't open $file: $!\n";
> my $text = do { local($/) ; <$f> };
>
This seems to have not been picked up, and would be useful for the tool
to have both for the kernel itself and other projects which also use it
and MAINTAINERS files. Can this please be picked up? Thanks!
--
Tom
next prev parent reply other threads:[~2023-10-28 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 21:17 [PATCH RESEND] get_maintainer: add email addresses from dts files Joe Perches
2023-10-28 17:46 ` Tom Rini [this message]
2023-11-06 18:21 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2021-08-09 8:02 Shawn Guo
2021-08-09 8:10 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231028174656.GA3310672@bill-the-cat \
--to=trini@konsulko.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).