Re: [PATCH v19 060/130] KVM: x86/tdp_mmu: Apply mmu notifier callback to only shared GPA

[Isaku Yamahata <isaku.yamahata@intel.com>]

On Thu, Mar 28, 2024 at 04:29:50PM +0800,
Binbin Wu <binbin.wu@linux.intel.com> wrote:

> 
> 
> On 2/26/2024 4:26 PM, isaku.yamahata@intel.com wrote:
> > From: Isaku Yamahata <isaku.yamahata@intel.com>
> > 
> > The private GPAs that typically guest memfd backs aren't subject to MMU
> > notifier because it isn't mapped into virtual address of user process.
> > kvm_tdp_mmu_handle_gfn() handles the callback of the MMU notifier,
> > clear_flush_young(), clear_young(), test_young()() and change_pte().  Make
>                                                    ^
>                                                    an extra "()"

Will fix it. Thanks.

> > kvm_tdp_mmu_handle_gfn() aware of private mapping and skip private mapping.
> > 
> > Even with AS_UNMOVABLE set, those mmu notifier are called.  For example,
> > ksmd triggers change_pte().
> 
> The description about the "AS_UNMOVABLE", you are refering to shared memory,
> right?
> Then, it seems not related to the change of this patch.

Ok, will remove this sentence.
-- 
Isaku Yamahata <isaku.yamahata@intel.com>