From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jeongjun Park <aha310510@gmail.com>
Cc: syzbot+6c21aeb59d0e82eb2782@syzkaller.appspotmail.com,
stefanha@redhat.com, sgarzare@redhat.com, jasowang@redhat.com,
kvm@vger.kernel.org, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH virt] virt: fix uninit-value in vhost_vsock_dev_open
Date: Sat, 20 Apr 2024 06:05:15 -0400 [thread overview]
Message-ID: <20240420060450-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240420085750.64274-1-aha310510@gmail.com>
On Sat, Apr 20, 2024 at 05:57:50PM +0900, Jeongjun Park wrote:
> Change vhost_vsock_dev_open() to use kvzalloc() instead of kvmalloc()
> to avoid uninit state.
>
> Reported-by: syzbot+6c21aeb59d0e82eb2782@syzkaller.appspotmail.com
> Fixes: dcda9b04713c ("mm, tree wide: replace __GFP_REPEAT by __GFP_RETRY_MAYFAIL with more useful semantic")
> Signed-off-by: Jeongjun Park <aha310510@gmail.com>
What value exactly is used uninitialized?
> ---
> drivers/vhost/vsock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> index ec20ecff85c7..652ef97a444b 100644
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -656,7 +656,7 @@ static int vhost_vsock_dev_open(struct inode *inode, struct file *file)
> /* This struct is large and allocation could fail, fall back to vmalloc
> * if there is no other way.
> */
> - vsock = kvmalloc(sizeof(*vsock), GFP_KERNEL | __GFP_RETRY_MAYFAIL);
> + vsock = kvzalloc(sizeof(*vsock), GFP_KERNEL | __GFP_RETRY_MAYFAIL);
> if (!vsock)
> return -ENOMEM;
>
> --
> 2.34.1
next prev parent reply other threads:[~2024-04-20 10:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 9:39 [syzbot] [virt?] [net?] KMSAN: uninit-value in vsock_assign_transport (2) syzbot
2024-04-19 12:39 ` Jeongjun Park
2024-04-19 14:44 ` syzbot
2024-04-19 14:56 ` Jeongjun Park
2024-04-19 15:39 ` syzbot
2024-04-20 8:57 ` [PATCH virt] virt: fix uninit-value in vhost_vsock_dev_open Jeongjun Park
2024-04-20 10:05 ` Michael S. Tsirkin [this message]
2024-04-21 3:06 ` Jeongjun Park
2024-04-22 13:00 ` Stefan Hajnoczi
2024-04-22 14:20 ` Michael S. Tsirkin
2024-05-05 19:53 ` Arseniy Krasnov
2024-04-22 14:18 ` [syzbot] [virt?] [net?] KMSAN: uninit-value in vsock_assign_transport (2) Michael S. Tsirkin
2024-04-23 1:31 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240420060450-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=aha310510@gmail.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=syzbot+6c21aeb59d0e82eb2782@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).