From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Wander Lairson Costa <wander@redhat.com>,
kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@google.com>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Maxime Ripard <mripard@kernel.org>, Rae Moar <rmoar@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] kunit: unregister the device on error
Date: Sat, 20 Apr 2024 08:27:20 +0200 [thread overview]
Message-ID: <2024042013-condition-glade-90e4@gregkh> (raw)
In-Reply-To: <bf0dc8a8-d5e9-4402-8305-5b7a954e6382@web.de>
On Fri, Apr 19, 2024 at 06:32:05PM +0200, Markus Elfring wrote:
> > > kunit_init_device() should unregister the device on bus register error,
> > > but mistakenly it tries to unregister the bus.
> > >
> > > Unregister the device instead of the bus.
> …
> > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Would you ever like to distinguish hardware register errors from
> item registration failures according to further improved commit messages?
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2024-04-20 6:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 13:25 [PATCH v4 0/2] kunit: fix minor error path mistakes Wander Lairson Costa
2024-04-19 13:25 ` [PATCH v4 1/2] kunit: unregister the device on error Wander Lairson Costa
2024-04-19 14:04 ` Greg Kroah-Hartman
2024-04-19 16:32 ` Markus Elfring
2024-04-20 6:27 ` Greg Kroah-Hartman [this message]
2024-04-19 13:25 ` [PATCH v4 2/2] kunit: avoid memory leak on device register error Wander Lairson Costa
2024-04-19 14:03 ` Greg Kroah-Hartman
2024-04-19 14:11 ` Wander Lairson Costa
2024-04-23 8:00 ` David Gow
2024-04-19 16:18 ` [PATCH v4 0/2] kunit: fix minor error path mistakes Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024042013-condition-glade-90e4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Markus.Elfring@web.de \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=mripard@kernel.org \
--cc=rmoar@google.com \
--cc=skhan@linuxfoundation.org \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).