From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel@ffwll.ch>,
"Liu, Chuansheng" <chuansheng.liu@intel.com>,
"alexander.deucher@amd.com" <alexander.deucher@amd.com>,
"airlied@redhat.com" <airlied@redhat.com>,
"'linux-kernel@vger.kernel.org' (linux-kernel@vger.kernel.org)"
<linux-kernel@vger.kernel.org>,
"Shi, Yang A" <yang.a.shi@intel.com>
Subject: Re: [Patch 0/1]drm_irq: Introducing the irq_thread support
Date: Thu, 11 Oct 2012 14:07:11 +0200 [thread overview]
Message-ID: <2047810.N82l1KJrzR@avalon> (raw)
In-Reply-To: <20120905132724.GC5357@phenom.ffwll.local>
On Wednesday 05 September 2012 15:27:24 Daniel Vetter wrote:
> On Wed, Sep 05, 2012 at 01:53:44AM +0000, Liu, Chuansheng wrote:
> > This patch is for introducing the irq thread support in drm_irq.
> >
> > Why we need irq thread in drm_irq code?
> > In our GPU system, the gpu interrupt handler need some time even > 1ms to
> > finish, in that case, the whole system will stay in irq disable status.
> > One case is: when audio is playing, it sometimes effects the audio
> > quality.
> >
> > So we have to introduce the irq thread in drm_irq, it can help us move
> > some heavy work into irq thread and other irq interrupts can be handled
> > in time. Also the IRQF_ONESHOT is helpful for irq thread.
> >
> > Include one patch:
> > [PATCH 01/1] drm_irq-Introducing-the-irq_thread-support
>
> For a kms drm driver (and tbh, doing a non-kms driver today is not a great
> idea), there's no reason to use the drm_irq_install/_unistall helpers.
Should the documenation be updated to mark those functions as deprecated for
new drivers and explain how to handle IRQ (un)registration manually ?
> So if you driver has special needs wrt irq handling that don't neatly fit
> what the drm_irq stuff provides, simply don't use it - all the generic
> code that's there is just to keep non-kms userspace going.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-10-11 12:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 1:53 [Patch 0/1]drm_irq: Introducing the irq_thread support Liu, Chuansheng
2012-09-05 12:49 ` Alan Cox
2012-09-06 0:42 ` Liu, Chuansheng
2012-09-06 7:39 ` Daniel Vetter
2012-09-05 13:27 ` Daniel Vetter
2012-09-05 15:12 ` Shi, Yang A
2012-09-05 15:32 ` Daniel Vetter
2012-09-06 0:54 ` Liu, Chuansheng
2012-09-05 15:47 ` Rob Clark
2012-09-06 0:48 ` Liu, Chuansheng
2012-10-11 12:07 ` Laurent Pinchart [this message]
2012-10-11 13:19 ` Rob Clark
2012-10-11 15:18 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2047810.N82l1KJrzR@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=chuansheng.liu@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.a.shi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).