From: David Howells <dhowells@redhat.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: dhowells@redhat.com, sprabhu@redhat.com, christian@brauner.io,
selinux@vger.kernel.org, keyrings@vger.kernel.org,
linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org
Subject: Re: [PATCH 1/2] Add namespace tags that can be used for matching without pinning a ns
Date: Fri, 05 Feb 2021 08:25:35 +0000 [thread overview]
Message-ID: <2094924.1612513535@warthog.procyon.org.uk> (raw)
In-Reply-To: <YByxkDi0Ruhb0AA8@kernel.org>
Jarkko Sakkinen <jarkko@kernel.org> wrote:
> > + * init_ns_common - Initialise the common part of a namespace
>
> Nit: init_ns_common()
Interesting. The majority of code doesn't put the brackets in.
> I've used lately (e.g. arch/x86/kernel/cpu/sgx/ioctl.c) along the lines:
>
> * Return:
> * - 0: Initialization was successful.
> * - -ENOMEM: Out of memory.
Actually, looking at kernel-doc.rst, this isn't necessarily the recommended
approach as it will much everything into one line, complete with dashes, and
can't handle splitting over lines. You probably meant:
* Return:
* * 0 - OK to runtime suspend the device
* * -EBUSY - Device should not be runtime suspended
> * Return:
> * - 0: Initialization was successful.
> * - -ENOMEM: Out of memory.
>
> Looking at the implementation, I guess this is a complete representation of
> what it can return?
It isn't. It can return at least -ENOSPC as well, but it's awkward detailing
the errors from functions it calls since they can change and then the
description here is wrong. I'm not sure there's a perfect answer to that.
David
next prev parent reply other threads:[~2021-02-05 8:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 17:47 [RFC][PATCH 0/2] keys: request_key() interception in containers David Howells
2021-02-04 17:47 ` [PATCH 1/2] Add namespace tags that can be used for matching without pinning a ns David Howells
2021-02-04 20:14 ` kernel test robot
2021-02-04 20:58 ` kernel test robot
2021-02-05 2:46 ` Jarkko Sakkinen
2021-02-05 8:25 ` David Howells [this message]
2021-02-07 23:55 ` Jarkko Sakkinen
2021-02-04 17:47 ` [PATCH 2/2] keys: Allow request_key upcalls from a container to be intercepted David Howells
2021-02-04 19:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2094924.1612513535@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=christian@brauner.io \
--cc=containers@lists.linux-foundation.org \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=selinux@vger.kernel.org \
--cc=sprabhu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).