linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Aakash Hemadri <aakashhemadri123@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Phillip Potter <phil@philpotter.co.uk>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] staging: r8188eu: incorrect type in assignment
Date: Sun, 22 Aug 2021 15:25:05 -0500	[thread overview]
Message-ID: <2188755e-33b1-bbe9-6f9b-e184830612ba@lwfinger.net> (raw)
In-Reply-To: <876b83dad76a6f561879da0db1fbb25b251374d4.1629562355.git.aakashhemadri123@gmail.com>

On 8/21/21 11:18 AM, Aakash Hemadri wrote:
> Fix sparse warning:
>> rtw_br_ext.c:516:57: warning: incorrect type in assignment
>      (different base types)
>> rtw_br_ext.c:516:57:    expected unsigned short
>> rtw_br_ext.c:516:57:    got restricted __be16 [usertype]
> 
> *pMagic holds __be16 change it's type to __be16
> 
> Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
> ---
>   drivers/staging/r8188eu/core/rtw_br_ext.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c
> index 83a4594a4214..14cf13516d34 100644
> --- a/drivers/staging/r8188eu/core/rtw_br_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c
> @@ -474,7 +474,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method)
>   		/*                Handle PPPoE frame                 */
>   		/*---------------------------------------------------*/
>   		struct pppoe_hdr *ph = (struct pppoe_hdr *)(skb->data + ETH_HLEN);
> -		unsigned short *pMagic;
> +		__be16 *pMagic;
>   
>   		switch (method) {
>   		case NAT25_CHECK:
> @@ -512,7 +512,7 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method)
>   						tag->tag_len = htons(MAGIC_CODE_LEN+RTL_RELAY_TAG_LEN+old_tag_len);
>   
>   						/*  insert the magic_code+client mac in relay tag */
> -						pMagic = (unsigned short *)tag->tag_data;
> +						pMagic = (__be16 *)tag->tag_data;
>   						*pMagic = htons(MAGIC_CODE);
>   						memcpy(tag->tag_data+MAGIC_CODE_LEN, skb->data+ETH_ALEN, ETH_ALEN);
>   
> 

For all 5 patches,

Ack by Larry Finger <Larry.finger#lwfinger.net>

Thanks,

Larry


  reply	other threads:[~2021-08-22 20:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-21 16:18 [PATCH v3 0/5] staging: r8188eu: fix sparse warnings Aakash Hemadri
2021-08-21 16:18 ` [PATCH v3 1/5] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-08-21 17:23   ` Phillip Potter
2021-08-21 16:18 ` [PATCH v3 2/5] staging: r8188eu: cast to restricted __be32 Aakash Hemadri
2021-08-23  8:44   ` Aakash Hemadri
2021-08-23 14:24     ` Larry Finger
2021-08-25  9:13       ` David Laight
2021-08-25  9:19         ` Dan Carpenter
2021-08-25 10:21           ` David Laight
2021-08-25 10:39             ` Dan Carpenter
2021-08-21 16:18 ` [PATCH v3 3/5] staging: r8188eu: incorrect type in csum_ipv6_magic Aakash Hemadri
2021-08-21 16:18 ` [PATCH v3 4/5] staging: r8188eu: restricted __be16 degrades to int Aakash Hemadri
2021-08-21 16:18 ` [PATCH v3 5/5] staging: r8188eu: incorrect type in assignment Aakash Hemadri
2021-08-22 20:25   ` Larry Finger [this message]
2021-08-21 16:20 ` [PATCH v3 0/5] staging: r8188eu: fix sparse warnings Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2188755e-33b1-bbe9-6f9b-e184830612ba@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=aakashhemadri123@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).