From: Peter Rosin <peda@axentia.se>
To: Guenter Roeck <linux@roeck-us.net>, linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
Ken Chen <chen.kenyy@inventec.com>,
joel@jms.id.au, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 2/3] i2c: mux: pca9541: namespace cleanup
Date: Tue, 20 Mar 2018 22:48:40 +0100 [thread overview]
Message-ID: <23103b1d-8f33-7885-379b-384382953a42@axentia.se> (raw)
In-Reply-To: <e92c5457-20fd-1e6e-ab59-5ff53e647e89@roeck-us.net>
On 2018-03-20 14:20, Guenter Roeck wrote:
> On 03/20/2018 02:31 AM, Peter Rosin wrote:
>> +static int pca9541_mybus(int ctl)
>
> bool ?
>
>> +{
>> + if (!(ctl & PCA9541_MYBUS))
>> + return 1;
>
> true ?
>
>> + return (ctl & PCA9541_MYBUS) == PCA9541_MYBUS;
>> +}
>> +
>> +static int pca9541_busoff(int ctl)
>
> bool ?
>
>> +{
>> + if (!(ctl & PCA9541_BUSON))
>> + return 1;
>
> true ?
bool? true? Isn't that C++? Sigh, but you're right, and old habits
die hard...
Would it be ok to add your reviewed-by tag as I fix that?
Cheers,
Peter
next prev parent reply other threads:[~2018-03-20 21:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 6:19 [PATCH linux dev-4.16 v2] i2c: muxes: pca9641: new driver Ken Chen
2018-03-20 6:34 ` Joel Stanley
2018-03-20 9:31 ` Peter Rosin
2018-03-20 9:31 ` [PATCH 1/3] i2c: mux: pca9541: use the BIT macro Peter Rosin
2018-03-20 13:18 ` Guenter Roeck
2018-03-20 23:25 ` Vladimir Zapolskiy
2018-03-20 9:31 ` [PATCH 2/3] i2c: mux: pca9541: namespace cleanup Peter Rosin
2018-03-20 13:20 ` Guenter Roeck
2018-03-20 21:48 ` Peter Rosin [this message]
2018-03-20 21:57 ` Guenter Roeck
2018-03-20 23:24 ` Vladimir Zapolskiy
2018-03-21 5:53 ` Peter Rosin
2018-03-21 6:54 ` Vladimir Zapolskiy
2018-03-21 7:35 ` Peter Rosin
2018-03-20 9:32 ` [PATCH 3/3] i2c: mux: pca9541: prepare for PCA9641 support Peter Rosin
2018-03-20 13:22 ` Guenter Roeck
2018-03-20 23:17 ` Vladimir Zapolskiy
2018-03-21 1:19 ` Guenter Roeck
2018-03-21 7:01 ` Vladimir Zapolskiy
2018-03-21 8:09 ` Peter Rosin
2018-03-21 7:05 ` Vladimir Zapolskiy
2018-04-11 9:37 ` [PATCH linux dev-4.16 v2] i2c: muxes: pca9641: new driver Peter Rosin
2018-04-13 6:59 ` ChenKenYY 陳永營 TAO
2018-04-13 7:27 ` Peter Rosin
2018-04-16 7:37 ` ChenKenYY 陳永營 TAO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23103b1d-8f33-7885-379b-384382953a42@axentia.se \
--to=peda@axentia.se \
--cc=chen.kenyy@inventec.com \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).