From: YueHaibing <yuehaibing@huawei.com>
To: Daniel Axtens <dja@axtens.net>, <ruscur@russell.cc>,
<oohall@gmail.com>, <mpe@ellerman.id.au>,
<benh@kernel.crashing.org>, <paulus@samba.org>
Cc: <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] powerpc/eeh: Remove unused inline function eeh_dev_phb_init_dynamic()
Date: Wed, 31 Mar 2021 20:58:42 +0800 [thread overview]
Message-ID: <238925b8-c2be-8282-1ce6-e1d92b7b527e@huawei.com> (raw)
In-Reply-To: <874kgy8ptt.fsf@linkitivity.dja.id.au>
On 2021/3/26 13:08, Daniel Axtens wrote:
> Hi,
>
>> commit 475028efc708 ("powerpc/eeh: Remove eeh_dev_phb_init_dynamic()")
>> left behind this, so can remove it.
>
> I had a look: the inline that you are removing here is for the
> !CONFIG_EEH case, which explains why it was missed the first time.
>
> This looks like a good change. Out of interest, what tool are you using
> to find these unused inlines? If there are many more, it might make
> sense to combine future patches removing them into a single patch, but
> I'm not sure.
Just use some grep skill, will do that if any.
>
> checkpatch likes this patch, so that's also good :)
>
> Reviewed-by: Daniel Axtens <dja@axtens.net>
>
> Kind regards,
> Daniel
> .
>
prev parent reply other threads:[~2021-03-31 12:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 14:07 [PATCH -next] powerpc/eeh: Remove unused inline function eeh_dev_phb_init_dynamic() YueHaibing
2021-03-26 5:08 ` Daniel Axtens
2021-03-31 12:58 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=238925b8-c2be-8282-1ce6-e1d92b7b527e@huawei.com \
--to=yuehaibing@huawei.com \
--cc=benh@kernel.crashing.org \
--cc=dja@axtens.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).