From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Luis de Oliveira <luis.oliveira@synopsys.com>
Cc: Rob Herring <robh@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
joao.pinto@synopsys.com, festevam@gmail.com,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Neil Armstrong <narmstrong@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Keiichi Watanabe <keiichiw@chromium.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Todor Tomov <todor.tomov@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [V3, 3/4] Documentation: dt-bindings: media: Document bindings for DW MIPI CSI-2 Host
Date: Wed, 14 Nov 2018 22:16:01 +0200 [thread overview]
Message-ID: <2394629.R0NRNf7gSs@avalon> (raw)
In-Reply-To: <45d87050-c5a8-dd96-20ae-d4951b0f4564@synopsys.com>
Hi Luis,
Thank you for the patch.
On Tuesday, 13 November 2018 12:00:22 EET Luis de Oliveira wrote:
> On 24-Oct-18 18:40, Rob Herring wrote:
> > On Fri, Oct 19, 2018 at 02:52:25PM +0200, Luis Oliveira wrote:
> >> Add bindings for Synopsys DesignWare MIPI CSI-2 host.
> >>
> >> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
> >> ---
> >> Changelog
> >> v2-V3
> >> - removed IPI settings
> >>
> >> .../devicetree/bindings/media/snps,dw-csi-plat.txt | 52 ++++++++++++++++
> >> 1 file changed, 52 insertions(+)
> >> create mode 100644
> >> Documentation/devicetree/bindings/media/snps,dw-csi-plat.txt>>
> >> diff --git a/Documentation/devicetree/bindings/media/snps,dw-csi-plat.txt
> >> b/Documentation/devicetree/bindings/media/snps,dw-csi-plat.txt new file
> >> mode 100644
> >> index 0000000..be3da05
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/media/snps,dw-csi-plat.txt
> >> @@ -0,0 +1,52 @@
> >> +Synopsys DesignWare CSI-2 Host controller
> >> +
> >> +Description
> >> +-----------
> >> +
> >> +This HW block is used to receive image coming from an MIPI CSI-2
> >> compatible +camera.
> >> +
> >> +Required properties:
> >> +- compatible: shall be "snps,dw-csi-plat"
> >
> > 'plat' is really part of the name of the h/w block?
>
> It is the name of the platform driver for CSI compatible with this block. Is
> that wrong?
DT bindings describe hardware, not drivers. This should be the name of the IP
core, regardless of how the drivers are architectured and named.
> >> +- reg : physical base address and size of the device memory
> >> mapped
> >> + registers;
> >> +- interrupts : CSI-2 Host interrupt
> >> +- snps,output-type : Core output to be used (IPI-> 0 or IDI->1 or
> >> BOTH->2)
> >> + These values choose which of the Core outputs will be used,
> >> + it can be Image Data Interface or Image Pixel Interface.
Does this describe what outputs the IP core has been instantiated
(synthesized) with, or what output(s) are used at runtime ? How does that
relate to the port nodes ?
> >> +- phys : List of one PHY specifier (as defined in
> >> + Documentation/devicetree/bindings/phy/phy-bindings.txt).
> >> + This PHY is a MIPI DPHY working in RX mode.
> >> +- resets : Reference to a reset controller (optional)
> >> +
> >> +The per-board settings:
> >> + - port sub-node describing a single endpoint connected to the camera as
> >> + described in video-interfaces.txt[1].
> >
> > Need to say 2 ports and what is each port? Why no port #0?
>
> I will elaborate on that.
>
> >> +
> >> +Example:
> >> +
> >> + csi2_1: csi2@3000 {
> >> + compatible = "snps,dw-csi-plat";
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> + reg = < 0x03000 0x7FF>;
> >> + interrupts = <2>;
> >> + output-type = <2>;
> >> + resets = <&dw_rst 1>;
> >> + phys = <&mipi_dphy_rx1 0>;
> >> + phy-names = "csi2-dphy";
> >
> > Not documented. Not really needed for a single entry, so I'd just drop
> > it.
>
> I will, thanks.
>
> >> +
> >> + /* CSI-2 per-board settings */
> >> + port@1 {
> >> + reg = <1>;
> >> + csi1_ep1: endpoint {
> >> + remote-endpoint = <&camera_1>;
> >> + data-lanes = <1 2>;
> >> + };
> >> + };
> >> + port@2 {
> >> + csi1_ep2: endpoint {
> >> + remote-endpoint = <&vif1_ep>;
> >> + };
> >> + };
> >> + };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-11-14 20:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 12:52 [V3, 0/4] platform: dwc: Add of DesignWare MIPI CSI-2 Host Luis Oliveira
2018-10-19 12:52 ` [V3, 1/4] Documentation: dt-bindings: phy: Document the Synopsys MIPI DPHY Rx bindings Luis Oliveira
2018-10-24 17:36 ` Rob Herring
2018-11-13 8:58 ` Luis Oliveira
2018-11-13 9:30 ` Luis de Oliveira
2018-11-14 20:08 ` Laurent Pinchart
2018-10-19 12:52 ` [V3, 2/4] media: platform: dwc: Add DW MIPI DPHY Rx platform Luis Oliveira
2019-01-07 11:58 ` Sakari Ailus
2019-01-08 9:17 ` Luis de Oliveira
2018-10-19 12:52 ` [V3, 3/4] Documentation: dt-bindings: media: Document bindings for DW MIPI CSI-2 Host Luis Oliveira
2018-10-24 17:40 ` Rob Herring
2018-11-13 10:00 ` Luis de Oliveira
2018-11-14 20:16 ` Laurent Pinchart [this message]
2018-10-24 17:41 ` Rob Herring
2018-11-13 10:00 ` Luis de Oliveira
2019-01-11 15:29 ` Eugen.Hristev
2018-10-19 12:52 ` [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver Luis Oliveira
2018-11-14 20:22 ` Laurent Pinchart
2019-01-10 17:00 ` Luis de Oliveira
2018-12-10 12:39 ` Eugen.Hristev
2019-01-10 16:11 ` Luis de Oliveira
2019-01-09 13:07 ` Eugen.Hristev
2019-01-10 16:18 ` Luis de Oliveira
2019-01-11 7:25 ` Eugen.Hristev
2019-01-11 8:11 ` Luis de Oliveira
2019-01-11 9:49 ` Eugen.Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2394629.R0NRNf7gSs@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=hans.verkuil@cisco.com \
--cc=joao.pinto@synopsys.com \
--cc=keiichiw@chromium.org \
--cc=kstewart@linuxfoundation.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=luis.oliveira@synopsys.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=todor.tomov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).