From: Ezequiel Garcia <ezequiel@collabora.com>
To: Justin Swartz <justin.swartz@risingedge.co.za>,
Jacob Chen <jacob-chen@iotwrt.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] media: rockchip/rga: add rk3228-rga to rockchip_rga_match[]
Date: Tue, 21 Jan 2020 07:45:01 -0300 [thread overview]
Message-ID: <241033bf82fc7e955dd20c0084bfd4f6fc9fc75b.camel@collabora.com> (raw)
In-Reply-To: <20200120194158.25357-1-justin.swartz@risingedge.co.za>
On Mon, 2020-01-20 at 19:41 +0000, Justin Swartz wrote:
> Add an entry to the rockchip_rga_match array for "rockchip,rk3228-rga"
>
> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
> ---
> drivers/media/platform/rockchip/rga/rga.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c
> index e9ff12b6b..268116cd5 100644
> --- a/drivers/media/platform/rockchip/rga/rga.c
> +++ b/drivers/media/platform/rockchip/rga/rga.c
> @@ -956,6 +956,9 @@ static const struct dev_pm_ops rga_pm = {
>
> static const struct of_device_id rockchip_rga_match[] = {
> {
> + .compatible = "rockchip,rk3228-rga",
> + },
Unless you need to tune something in the driver
specifically for rk3228, then you don't need a
new compatible string.
As the name implies, it's just a "compatible",
so you may simply declare your rga dts node as
compatible to "rockchip,rk3288-rga".
(Of course, this means we shouldn't have added
the rk3399 compatible string.)
Regards,
Ezequiel
next prev parent reply other threads:[~2020-01-21 10:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 19:41 [PATCH 1/4] media: rockchip/rga: add rk3228-rga to rockchip_rga_match[] Justin Swartz
2020-01-20 19:41 ` [PATCH 2/4] [media] dt-bindings: Add rk3228 to the Rockchip RGA binding doc Justin Swartz
2020-01-20 19:41 ` [PATCH 3/4] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-01-20 19:41 ` [PATCH 4/4] ARM: dts: rockchip: add rga to rk3229-xms6 Justin Swartz
2020-01-21 10:45 ` Ezequiel Garcia [this message]
2020-01-21 11:51 ` [PATCH 1/4] media: rockchip/rga: add rk3228-rga to rockchip_rga_match[] Justin Swartz
2020-01-21 13:01 ` Heiko Stuebner
2020-01-21 20:11 ` [PATCH v2 0/2] Add rga to rk322x device tree Justin Swartz
2020-01-21 20:11 ` [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-01-21 21:34 ` Johan Jonker
2020-01-21 21:45 ` Justin Swartz
2020-01-21 20:11 ` [PATCH v2 2/2] ARM: dts: rockchip: enable rga for rk3229-xms6 Justin Swartz
2020-01-21 22:02 ` [PATCH v3 0/2] Add rga to rk322x device tree Justin Swartz
2020-01-21 22:02 ` [PATCH v3 1/2] ARM: dts: rockchip: add rga node for rk322x Justin Swartz
2020-01-21 22:02 ` [PATCH v3 2/2] ARM: dts: rockchip: enable rga for rk3229-xms6 Justin Swartz
2020-02-03 10:36 ` [PATCH v3 0/2] Add rga to rk322x device tree Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=241033bf82fc7e955dd20c0084bfd4f6fc9fc75b.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=jacob-chen@iotwrt.com \
--cc=justin.swartz@risingedge.co.za \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).