From: Florian Fainelli <f.fainelli@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net, hkallweit1@gmail.com, robh@kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY
Date: Wed, 4 Nov 2020 19:03:15 -0800 [thread overview]
Message-ID: <2513627e-42d4-88d5-c8fe-f4b90b1b56b5@gmail.com> (raw)
In-Reply-To: <f44af428-acd9-daef-3609-4d6ea24cd436@ti.com>
On 11/3/2020 9:35 AM, Dan Murphy wrote:
> Andrew
>
> On 11/3/20 11:18 AM, Andrew Lunn wrote:
>> On Tue, Nov 03, 2020 at 11:07:00AM -0600, Dan Murphy wrote:
>>> Andrew
>>>
>>> On 10/30/20 3:15 PM, Andrew Lunn wrote:
>>>>> +static int dp83td510_config_init(struct phy_device *phydev)
>>>>> +{
>>>>> + struct dp83td510_private *dp83td510 = phydev->priv;
>>>>> + int mst_slave_cfg;
>>>>> + int ret = 0;
>>>>> +
>>>>> + if (phy_interface_is_rgmii(phydev)) {
>>>>> + if (dp83td510->rgmii_delay) {
>>>>> + ret = phy_set_bits_mmd(phydev, DP83TD510_DEVADDR,
>>>>> + DP83TD510_MAC_CFG_1,
>>>>> dp83td510->rgmii_delay);
>>>>> + if (ret)
>>>>> + return ret;
>>>>> + }
>>>>> + }
>>>> Hi Dan
>>>>
>>>> I'm getting a bit paranoid about RGMII delays...
>>> Not sure what this means.
>> See the discussion and breakage around the realtek PHY. It wrongly
>> implemented RGMII delays. When it was fixed, lots of board broke
>> because the bug in the PHY driver hid bugs in the DT.
>>
> I will have to go find that thread. Do you have a link?
That would be the thread:
https://lore.kernel.org/netdev/CAMj1kXEEF_Un-4NTaD5iUN0NoZYaJQn-rPediX0S6oRiuVuW-A@mail.gmail.com/
--
Florian
next prev parent reply other threads:[~2020-11-05 3:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 17:29 [PATCH net-next v3 0/4] DP83TD510 Single Pair 10Mbps Ethernet PHY Dan Murphy
2020-10-30 17:29 ` [PATCH net-next v3 1/4] ethtool: Add 10base-T1L link mode entries Dan Murphy
2020-10-30 19:43 ` Andrew Lunn
2020-11-05 2:42 ` Florian Fainelli
2020-10-30 17:29 ` [PATCH net-next v3 2/4] dt-bindings: net: Add Rx/Tx output configuration for 10base T1L Dan Murphy
2020-10-30 19:56 ` Andrew Lunn
2020-11-03 16:52 ` Dan Murphy
2020-11-03 17:07 ` Andrew Lunn
2020-11-04 22:08 ` Rob Herring
2020-10-30 17:29 ` [PATCH net-next v3 3/4] dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY Dan Murphy
2020-10-31 9:27 ` Ioana Ciornei
2020-11-02 17:12 ` Rob Herring
2020-10-30 17:29 ` [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the " Dan Murphy
2020-10-30 20:15 ` Andrew Lunn
2020-11-03 17:07 ` Dan Murphy
2020-11-03 17:18 ` Andrew Lunn
2020-11-03 17:35 ` Dan Murphy
2020-11-05 3:03 ` Florian Fainelli [this message]
2020-10-30 23:03 ` Jakub Kicinski
2020-11-03 17:09 ` Dan Murphy
2020-11-03 17:21 ` Andrew Lunn
2020-11-03 17:23 ` Dan Murphy
2020-11-03 17:38 ` Andrew Lunn
2020-10-31 9:18 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2513627e-42d4-88d5-c8fe-f4b90b1b56b5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).