From: Adrian Hunter <adrian.hunter@intel.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
linux-kernel@vger.kernel.org, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Cc: phil@raspberrypi.com, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, f.fainelli@gmail.com,
stefan.wahren@i2se.com, linux-rpi-kernel@lists.infradead.org,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v2 09/11] mmc: sdhci: iproc: Add custom set_power() callback for bcm2711
Date: Mon, 9 Mar 2020 09:29:02 +0200 [thread overview]
Message-ID: <254549a8-804a-eb8a-7fce-374852bbd9af@intel.com> (raw)
In-Reply-To: <20200306174413.20634-10-nsaenzjulienne@suse.de>
On 6/03/20 7:44 pm, Nicolas Saenz Julienne wrote:
> The controller needs a valid bus voltage in its power register
> regardless of whether an external regulator is taking care of the power
> supply.
>
> The sdhci core already provides a helper function for this,
> sdhci_set_power_and_bus_voltage(), so create a bcm2711 specific 'struct
> sdhci_ops' which makes use of it.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-iproc.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index f4f5f0a70cda..225603148d7d 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -261,9 +261,24 @@ static const struct sdhci_iproc_data bcm2835_data = {
> .mmc_caps = 0x00000000,
> };
>
> +static const struct sdhci_ops sdhci_iproc_bcm2711_ops = {
> + .read_l = sdhci_iproc_readl,
> + .read_w = sdhci_iproc_readw,
> + .read_b = sdhci_iproc_readb,
> + .write_l = sdhci_iproc_writel,
> + .write_w = sdhci_iproc_writew,
> + .write_b = sdhci_iproc_writeb,
> + .set_clock = sdhci_set_clock,
> + .set_power = sdhci_set_power_and_bus_voltage,
> + .get_max_clock = sdhci_iproc_get_max_clock,
> + .set_bus_width = sdhci_set_bus_width,
> + .reset = sdhci_reset,
> + .set_uhs_signaling = sdhci_set_uhs_signaling,
> +};
> +
> static const struct sdhci_pltfm_data sdhci_bcm2711_pltfm_data = {
> .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12,
> - .ops = &sdhci_iproc_32only_ops,
> + .ops = &sdhci_iproc_bcm2711_ops,
> };
>
> static const struct sdhci_iproc_data bcm2711_data = {
>
next prev parent reply other threads:[~2020-03-09 7:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 17:44 [PATCH v2 00/11] Raspbery Pi 4 vmmc regulator support Nicolas Saenz Julienne
2020-03-06 17:44 ` [PATCH v2 01/11] mmc: sdhci: Introduce sdhci_set_power_and_bus_voltage() Nicolas Saenz Julienne
2020-03-09 7:21 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 02/11] mmc: sdhci: arasan: Use sdhci_set_power_and_voltage() Nicolas Saenz Julienne
2020-03-09 7:22 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 03/11] mmc: sdhci: milbeaut: " Nicolas Saenz Julienne
2020-03-09 7:25 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 04/11] mmc: sdhci: at91: " Nicolas Saenz Julienne
2020-03-09 7:25 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 05/11] mmc: sdhci: pxav3: " Nicolas Saenz Julienne
2020-03-09 7:20 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 06/11] mmc: sdhci: xenon: " Nicolas Saenz Julienne
2020-03-09 7:20 ` Adrian Hunter
2020-03-09 10:53 ` Nicolas Saenz Julienne
2020-03-09 11:55 ` Adrian Hunter
2020-03-09 11:56 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 07/11] mmc: sdhci: am654: " Nicolas Saenz Julienne
2020-03-09 7:27 ` Adrian Hunter
2020-03-06 17:44 ` [PATCH v2 08/11] mmc: sdhci: Unexport sdhci_set_power_noreg() Nicolas Saenz Julienne
2020-03-06 17:44 ` [PATCH v2 09/11] mmc: sdhci: iproc: Add custom set_power() callback for bcm2711 Nicolas Saenz Julienne
2020-03-09 7:29 ` Adrian Hunter [this message]
2020-03-06 17:44 ` [PATCH v2 10/11] ARM: dts: bcm2711: Update expgpio's GPIO labels Nicolas Saenz Julienne
2020-03-27 11:21 ` Nicolas Saenz Julienne
2020-03-06 17:44 ` [PATCH v2 11/11] ARM: dts: bcm2711: Add vmmc regulator in emmc2 Nicolas Saenz Julienne
2020-03-09 20:00 ` Stefan Wahren
2020-03-09 20:01 ` Nicolas Saenz Julienne
2020-03-27 11:22 ` Nicolas Saenz Julienne
2020-03-12 13:08 ` [PATCH v2 00/11] Raspbery Pi 4 vmmc regulator support Ulf Hansson
2020-03-12 13:13 ` Nicolas Saenz Julienne
2020-03-12 14:06 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=254549a8-804a-eb8a-7fce-374852bbd9af@intel.com \
--to=adrian.hunter@intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).