linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
	Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload
Date: Fri, 11 Nov 2016 18:02:03 -0300	[thread overview]
Message-ID: <26cfc6a9-8589-a64d-58b6-010c595eabdb@osg.samsung.com> (raw)
In-Reply-To: <20161111194708.GA30151@roeck-us.net>

Hello Guenter,

On 11/11/2016 04:47 PM, Guenter Roeck wrote:
> Hi Javier,
> 
> On Fri, Nov 11, 2016 at 04:43:37PM -0300, Javier Martinez Canillas wrote:
>> Hello Guenter,
>>
>> On 10/14/2016 01:55 PM, Guenter Roeck wrote:
>>> On Fri, Oct 14, 2016 at 12:23:50PM -0300, Javier Martinez Canillas wrote:
>>>> If the driver is built as a module, autoload won't work because the module
>>>> alias information is not filled. So user-space can't match the registered
>>>> device with the corresponding module.
>>>>
>>>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>>>
>>>> Before this patch:
>>>>
>>>> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias
>>>> $
>>>>
>>>> After this patch:
>>>>
>>>> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias
>>>> alias:          of:N*T*Cbrcm,bcm7038-wdtC*
>>>> alias:          of:N*T*Cbrcm,bcm7038-wdt
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>>
>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>
>> Are you going to pick this (and patch 2/2)?
>>
>> I'm asking because you provided your r-b tag but the patch
>> was never merged, so I wonder who should I ping about it.
>>
> Wim would be the one to pick it.
> 
> Maybe it got lost.  I hope I'll find some time during the weekend
> to update my tracking branch.
> 

Ok, thanks a lot for the info.

> Guenter
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

      reply	other threads:[~2016-11-11 21:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-14 15:23 [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload Javier Martinez Canillas
2016-10-14 15:23 ` [PATCH 2/2] watchdog: max77620_wdt: " Javier Martinez Canillas
2016-10-14 16:56   ` Guenter Roeck
2016-10-14 16:55 ` [PATCH 1/2] watchdog: bcm7038_wdt: " Guenter Roeck
2016-11-11 19:43   ` Javier Martinez Canillas
2016-11-11 19:47     ` Guenter Roeck
2016-11-11 21:02       ` Javier Martinez Canillas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26cfc6a9-8589-a64d-58b6-010c595eabdb@osg.samsung.com \
    --to=javier@osg.samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).