From: Dmitry Safonov <dima@arista.com>
To: Max Filippov <jcmvbkbc@gmail.com>, linux-xtensa@linux-xtensa.org
Cc: Chris Zankel <chris@zankel.net>,
linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH] xtensa: improve stack dumping
Date: Wed, 6 Nov 2019 20:50:58 +0000 [thread overview]
Message-ID: <27720768-9fb7-0382-e1ef-ac9760cdf5cc@arista.com> (raw)
In-Reply-To: <20191106181617.1832-1-jcmvbkbc@gmail.com>
Hi Max,
On 11/6/19 6:16 PM, Max Filippov wrote:
> Collect whole stack dump lines in a buffer and print the whole buffer
> when it's ready with pr_info instead of pr_cont. This makes stack dump
> lines consistent in SMP case and relies less on pr_cont/printk
> differences related to timestamps.
> Make size of stack dump configurable.
> Drop extra newline output in show_trace as its output format does not
> depend on CONFIG_KALLSYMS.
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
[..]
> void show_stack(struct task_struct *task, unsigned long *sp)
> {
> int i = 0;
> unsigned long *stack;
> + char buf[9 * 8 + 1];
>
> if (!sp)
> sp = stack_pointer(task);
> @@ -512,10 +510,12 @@ void show_stack(struct task_struct *task, unsigned long *sp)
> for (i = 0; i < kstack_depth_to_print; i++) {
> if (kstack_end(sp))
> break;
> - pr_cont(" %08lx", *sp++);
> + sprintf(buf + (i % 8) * 9, " %08lx", *sp++);
buf is on the stack, does sprintf() put null-terminator for hex?
> if (i % 8 == 7)
> - pr_cont("\n");
> + pr_info("%s\n", buf);
> }
> + if (i % 8)
> + pr_info("%s\n", buf);
If the stack trace ends with (i % 8 == 7), you'll double-print the last
line?
Thanks,
Dmitry
next prev parent reply other threads:[~2019-11-06 20:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 18:16 [PATCH] xtensa: improve stack dumping Max Filippov
2019-11-06 20:50 ` Dmitry Safonov [this message]
2019-11-06 22:00 ` Max Filippov
2019-11-06 22:18 ` Dmitry Safonov
2019-11-06 22:33 ` Joe Perches
2019-11-07 0:21 ` Max Filippov
2019-11-07 14:38 ` Petr Mladek
2019-11-07 14:45 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27720768-9fb7-0382-e1ef-ac9760cdf5cc@arista.com \
--to=dima@arista.com \
--cc=chris@zankel.net \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).