From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Tao Ren <taoren@fb.com>, Thomas Gleixner <tglx@linutronix.de>
Cc: Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Yu Lei <mine260309@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2] clocksource/drivers/fttmr010: fix invalid interrupt register access
Date: Mon, 5 Nov 2018 19:50:31 +0100 [thread overview]
Message-ID: <279e6a06-3f2f-e736-f28e-4d099729a517@linaro.org> (raw)
In-Reply-To: <BC1ADE3F-F31F-4E1E-A6EE-3BD83C5F2634@fb.com>
On 05/11/2018 19:43, Tao Ren wrote:
> On 10/7/18, 2:03 PM, "Linus Walleij" <linus.walleij@linaro.org> wrote:
>>
>> On Wed, Oct 3, 2018 at 11:54 PM Tao Ren <taoren@fb.com> wrote:
>>
>>> TIMER_INTR_MASK register (Base Address of Timer + 0x38) is not designed
>>> for masking interrupts on ast2500 chips, and it's not even listed in
>>> ast2400 datasheet, so it's not safe to access TIMER_INTR_MASK on aspeed
>>> chips.
>>>
>>> Similarly, TIMER_INTR_STATE register (Base Address of Timer + 0x34) is
>>> not interrupt status register on ast2400 and ast2500 chips. Although
>>> there is no side effect to reset the register in fttmr010_common_init(),
>>> it's just misleading to do so.
>>>
>>> Besides, "count_down" is renamed to "is_aspeed" in "fttmr010" structure,
>>> and more comments are added so the code is more readble.
>>>
>>> Signed-off-by: Tao Ren <taoren@fb.com>
>>> ---
>>> Changes in v2:
>>> - "count_down" is renamed to "is_aspeed" in "fttmr010" structure.
>>> - more comments are added to make the code more readable.
>>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Hi Daniel / Thomas,
>
> Any further comments on the patch? Or is there anything needed from my side?
Oh right, sorry. Should it go to stable also ? Is there a Fixes tag it
can apply ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2018-11-05 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 21:53 [PATCH v2] clocksource/drivers/fttmr010: fix invalid interrupt register access Tao Ren
2018-10-07 21:03 ` Linus Walleij
2018-10-10 5:50 ` Tao Ren
2018-11-05 18:43 ` Tao Ren
2018-11-05 18:50 ` Daniel Lezcano [this message]
2018-11-05 19:00 ` Tao Ren
2018-12-07 1:13 ` Tao Ren
2018-12-07 7:04 ` Daniel Lezcano
2018-12-07 21:22 ` Tao Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=279e6a06-3f2f-e736-f28e-4d099729a517@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=linus.walleij@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mine260309@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=taoren@fb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).