From: Larry Finger <Larry.Finger@lwfinger.net>
To: Joe Perches <joe@perches.com>,
Colin King <colin.king@canonical.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S . Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: [PATCH] rtlwifi: rtl818x: fix indentation issue
Date: Thu, 17 Jan 2019 13:33:53 -0600 [thread overview]
Message-ID: <284e7ef0-5820-021b-7b0c-2fc754440fe8@lwfinger.net> (raw)
In-Reply-To: <e68c7ae7b0a863742df0f4457368a3a529ed47e5.camel@perches.com>
On 1/17/19 1:29 PM, Joe Perches wrote:
> On Thu, 2019-01-17 at 15:28 +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is a statement that is indented too deeply. Fix this.
>
> Thanks.
>
>> diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c b/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c
> []
>> @@ -803,7 +803,7 @@ static void rtl8180_config_cardbus(struct ieee80211_hw *dev)
>> rtl818x_iowrite16(priv, FEMR_SE, 0xffff);
>> } else {
>> reg16 = rtl818x_ioread16(priv, &priv->map->FEMR);
>> - reg16 |= (1 << 15) | (1 << 14) | (1 << 4);
>> + reg16 |= (1 << 15) | (1 << 14) | (1 << 4);
>> rtl818x_iowrite16(priv, &priv->map->FEMR, reg16);
>> }
>
> trivia:
>
> It sure looks as if there could be some rather useful
> conversions of magic bits to constants one day.
How much work is warranted for this driver for a device that is not likely in
use anywhere in the wild? In addition, I'm not sure anyone knows what those bits
actually do, I certainly do not have a product sheet for that one.
Larry
next prev parent reply other threads:[~2019-01-17 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 15:28 [PATCH] rtlwifi: rtl818x: fix indentation issue Colin King
2019-01-17 16:52 ` John W. Linville
2019-01-17 19:29 ` Joe Perches
2019-01-17 19:33 ` Larry Finger [this message]
2019-01-17 19:59 ` Joe Perches
2019-02-01 12:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=284e7ef0-5820-021b-7b0c-2fc754440fe8@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).