From: "David E. Box" <david.e.box@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
srinivas.pandruvada@intel.com, mgross@linux.intel.com
Cc: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH V7 2/3] tools arch x86: Add Intel SDSi provisiong tool
Date: Mon, 14 Feb 2022 10:47:30 -0800 [thread overview]
Message-ID: <29515b9c1a250b060174af74299ab6187e346387.camel@linux.intel.com> (raw)
In-Reply-To: <16187bb8-ebe6-f260-c255-530095472a03@redhat.com>
On Mon, 2022-02-14 at 11:56 +0100, Hans de Goede wrote:
> Hi,
>
> On 2/12/22 02:32, David E. Box wrote:
> > Add tool for key certificate and activation payload provisioning on
> > Intel CPUs supporting Software Defined Silicon (SDSi).
> >
> > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> > ---
> > V7
> > - No changes.
> > V6
> > - No changes.
> > V5
> > - Update copyright to 2022
> > V4
> > - No changes.
> > V3
> > - Move from samples to tools.
> > - Fix bit fields in availability structure.
> > - Check provisioning availability before issuing command.
> >
> > V2
> > - New patch.
> >
> > MAINTAINERS | 1 +
> > tools/arch/x86/intel_sdsi/Makefile | 9 +
> > tools/arch/x86/intel_sdsi/sdsi.c | 540 +++++++++++++++++++++++++++++
> > 3 files changed, 550 insertions(+)
> > create mode 100644 tools/arch/x86/intel_sdsi/Makefile
> > create mode 100644 tools/arch/x86/intel_sdsi/sdsi.c
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 29d0945f5a63..80325cbde3bd 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -9873,6 +9873,7 @@ INTEL SDSI DRIVER
> > M: David E. Box <david.e.box@linux.intel.com>
> > S: Supported
> > F: drivers/platform/x86/intel/sdsi.c
> > +F: tools/arch/x86/intel_sdsi/
> >
> > INTEL SKYLAKE INT3472 ACPI DEVICE DRIVER
> > M: Daniel Scally <djrscally@gmail.com>
> > diff --git a/tools/arch/x86/intel_sdsi/Makefile
> > b/tools/arch/x86/intel_sdsi/Makefile
> > new file mode 100644
> > index 000000000000..1c2d102ff8fb
> > --- /dev/null
> > +++ b/tools/arch/x86/intel_sdsi/Makefile
> > @@ -0,0 +1,9 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +
> > +.PHONY: sdsi
> > +
> > +sdsi: sdsi.o
> > + $(CC) -Wall $^ -o $@
> > +
> > +clean:
> > + rm *.o sdsi
>
> I assume that this is also going to be an official tool (next to a UI one?)
> which users may use to provision AKCs and CAPs ?
>
> In that case the binary really should also be named intel_sdsi like the
> directory
> and an install target should be added, see for example how:
>
> tools/arch/x86/kcpuid/Makefile
>
> does this.
Will do.
David
next prev parent reply other threads:[~2022-02-14 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-12 1:32 [PATCH V7 0/3] Intel Software Defined Silicon David E. Box
2022-02-12 1:32 ` [PATCH V7 1/3] platform/x86: Add Intel Software Defined Silicon driver David E. Box
2022-02-14 10:53 ` Hans de Goede
2022-02-12 1:32 ` [PATCH V7 2/3] tools arch x86: Add Intel SDSi provisiong tool David E. Box
2022-02-14 10:56 ` Hans de Goede
2022-02-14 18:47 ` David E. Box [this message]
2022-02-12 1:32 ` [PATCH V7 3/3] selftests: sdsi: test sysfs setup David E. Box
2022-02-14 11:10 ` Hans de Goede
2022-02-14 18:57 ` David E. Box
2022-02-14 20:00 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29515b9c1a250b060174af74299ab6187e346387.camel@linux.intel.com \
--to=david.e.box@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).