From: Michael Straube <straube.linux@gmail.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
martin@kaiser.cx, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] remove pointers from struct hal_ops
Date: Sat, 11 Sep 2021 12:24:09 +0200 [thread overview]
Message-ID: <296aa357-1bba-4136-c651-a18d04c8d32a@gmail.com> (raw)
In-Reply-To: <1858319.rr7sHpn3up@localhost.localdomain>
On 9/11/21 11:38, Fabio M. De Francesco wrote:
> On Friday, September 10, 2021 10:50:26 PM CEST Michael Straube wrote:
>> This series removes some more pointers from struct hal_ops and
>> removes the function rtl8188e_set_hal_ops() that is empty after
>> the removals.
>>
>> Michael Straube (7):
>> staging: r8188eu: remove mgnt_xmit from struct hal_ops
>> staging: r8188eu: remove hal_xmit from struct hal_ops
>> staging: r8188eu: remove read_bbreg from struct hal_ops
>> staging: r8188eu: remove write_bbreg from struct hal_ops
>> staging: r8188eu: remove read_rfreg from struct hal_ops
>> staging: r8188eu: remove write_rfreg from struct hal_ops
>> staging: r8188eu: remove rtl8188e_set_hal_ops()
>>
>
> Hi Michael,
>
> This series is good.
>
> Furthermore, I compiled the whole series with gcc version 11.2.1 2020816
> [revision 056e324ce46a7924b5cf10f61010cf9dd2ca10e9] (SUSE Linux) one
> patch at a time. There are no errors or warnings at any time in any of the
> seven builds.
>
> But, unfortunately, I have no time to test. So the whole series is...
>
> Acked-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
>
> Thanks,
>
> Fabio
>
Hi Fabio,
thank you for the review. I have tested it on x86_64 with
Inter-Tech DMG-02 connected to a CCMP network without any
issues.
Perhaps I should have mentioned that in the cover letter. ;)
Thanks,
Michael
next prev parent reply other threads:[~2021-09-11 10:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 20:50 [PATCH 0/7] remove pointers from struct hal_ops Michael Straube
2021-09-10 20:50 ` [PATCH 1/7] staging: r8188eu: remove mgnt_xmit " Michael Straube
2021-09-10 20:50 ` [PATCH 2/7] staging: r8188eu: remove hal_xmit " Michael Straube
2021-09-10 20:50 ` [PATCH 3/7] staging: r8188eu: remove read_bbreg " Michael Straube
2021-09-10 20:50 ` [PATCH 4/7] staging: r8188eu: remove write_bbreg " Michael Straube
2021-09-10 20:50 ` [PATCH 5/7] staging: r8188eu: remove read_rfreg " Michael Straube
2021-09-10 20:50 ` [PATCH 6/7] staging: r8188eu: remove write_rfreg " Michael Straube
2021-09-10 20:50 ` [PATCH 7/7] staging: r8188eu: remove rtl8188e_set_hal_ops() Michael Straube
2021-09-11 9:38 ` [PATCH 0/7] remove pointers from struct hal_ops Fabio M. De Francesco
2021-09-11 10:24 ` Michael Straube [this message]
2021-09-11 10:50 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=296aa357-1bba-4136-c651-a18d04c8d32a@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).