From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83AB3C432BE for ; Wed, 18 Aug 2021 16:25:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6104A610CB for ; Wed, 18 Aug 2021 16:25:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231719AbhHRQZk (ORCPT ); Wed, 18 Aug 2021 12:25:40 -0400 Received: from relay5.mymailcheap.com ([159.100.241.64]:49189 "EHLO relay5.mymailcheap.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230391AbhHRQZh (ORCPT ); Wed, 18 Aug 2021 12:25:37 -0400 X-Greylist: delayed 8306 seconds by postgrey-1.27 at vger.kernel.org; Wed, 18 Aug 2021 12:25:36 EDT Received: from relay2.mymailcheap.com (relay2.mymailcheap.com [151.80.165.199]) by relay5.mymailcheap.com (Postfix) with ESMTPS id 9DAF9200FD; Wed, 18 Aug 2021 16:25:00 +0000 (UTC) Received: from filter1.mymailcheap.com (filter1.mymailcheap.com [149.56.130.247]) by relay2.mymailcheap.com (Postfix) with ESMTPS id DDFE93ECDA; Wed, 18 Aug 2021 18:24:58 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by filter1.mymailcheap.com (Postfix) with ESMTP id 2DA222A0C8; Wed, 18 Aug 2021 12:24:58 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mymailcheap.com; s=default; t=1629303898; bh=Xj3ffOIhzV6P++lm20v3TPfWMR7pg4+1nIiD5/2tzLQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=G/lIEzIierlLLLAjYhLytITPmd3pvuhdcOfOdOTj3cO2Vxl575hnN33PghePcB2Oe Kaf7U3zW9S2w5VohX4wVNwa1O3qDyjULL48j3pVw8Bw80ViyR4Yts2e3GYzt31WeVB yuTDAj72J15bQJqy6OpHZq2NHM6vbgIgoQuYah8A= X-Virus-Scanned: Debian amavisd-new at filter1.mymailcheap.com Received: from filter1.mymailcheap.com ([127.0.0.1]) by localhost (filter1.mymailcheap.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HA0IYBIZ6BpN; Wed, 18 Aug 2021 12:24:53 -0400 (EDT) Received: from mail20.mymailcheap.com (mail20.mymailcheap.com [51.83.111.147]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by filter1.mymailcheap.com (Postfix) with ESMTPS; Wed, 18 Aug 2021 12:24:53 -0400 (EDT) Received: from [148.251.23.173] (ml.mymailcheap.com [148.251.23.173]) by mail20.mymailcheap.com (Postfix) with ESMTP id AE79F4118B; Wed, 18 Aug 2021 16:24:52 +0000 (UTC) Authentication-Results: mail20.mymailcheap.com; dkim=pass (1024-bit key; unprotected) header.d=aosc.io header.i=@aosc.io header.b="Nax/mXoP"; dkim-atps=neutral AI-Spam-Status: Not processed Received: from ice-e5v2.lan (unknown [59.41.161.108]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail20.mymailcheap.com (Postfix) with ESMTPSA id 582FA4118B; Wed, 18 Aug 2021 16:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aosc.io; s=default; t=1629303886; bh=Xj3ffOIhzV6P++lm20v3TPfWMR7pg4+1nIiD5/2tzLQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Nax/mXoPIddvcE6NKEtDDkKf0tC9zR1I1iu6na1xQFrD439zocZeZ7+2XvN8mMdPa ym0c/X8LpxRSh2dpI8eCrBKs1rTZ+541hbU2tUX5On5gpR7CQvK7S0mDGnCMfERr1s Qc5eo1UqKnaS4px6njiAKcVHJq+E6+NXj/XQihHE= Message-ID: <29ac3b3b11fa022c6411fe3d334cceb6146b2978.camel@aosc.io> Subject: Re: [PATCH] usb: typec: tcpm: always rediscover when swapping DR From: Icenowy Zheng To: Kyle Tso , Greg Kroah-Hartman Cc: Heikki Krogerus , Guenter Roeck , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 19 Aug 2021 00:24:41 +0800 In-Reply-To: References: <20210813043131.833006-1-icenowy@aosc.io> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: AE79F4118B X-Rspamd-Server: mail20.mymailcheap.com X-Spamd-Result: default: False [-0.10 / 10.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[aosc.io:s=default]; RECEIVED_SPAMHAUS_PBL(0.00)[59.41.161.108:received]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[aosc.io]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[6]; ML_SERVERS(-3.10)[148.251.23.173]; DKIM_TRACE(0.00)[aosc.io:+]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:148.251.0.0/16, country:DE]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; HFILTER_HELO_BAREIP(3.00)[148.251.23.173,1] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021-08-19星期四的 00:13 +0800，Kyle Tso写道： > On Wed, Aug 18, 2021 at 10:40 PM Greg Kroah-Hartman > wrote: > > > > On Wed, Aug 18, 2021 at 10:02:24PM +0800, Icenowy Zheng wrote: > > > > > > > > > 于 2021年8月18日 GMT+08:00 下午9:56:38, Greg Kroah-Hartman < > > > gregkh@linuxfoundation.org> 写到: > > > > On Tue, Aug 17, 2021 at 02:00:33PM +0300, Heikki Krogerus > > > > wrote: > > > > > > > Why is it necessary to do discovery with data role swap > > > > > > > in general? > > > > > > > > > > > > I think it could be possible for devices to expose > > > > > > different altmode > > > > > > with different role. > > > > > > > > > > OK. FWIW: > > > > > > > > > > Acked-by: Heikki Krogerus > > > > > > > > Is this conflicting with > > > > https://lore.kernel.org/r/20210816075449.2236547-1-kyletso@google.com > > > >  ? > > > > > > > > Which of these two should I take, both?  Neither? > > > > > > Don't take this, it's against spec. > > > > Ok, now dropped.  What about the linked patch above?  Does that > > work for > > you instead? > > > > thanks, > > > > greg k-h > > Hi Icenowy, > > Could you revisit the patch for the tcpm_unregister_altmodes part? > I think that is still a problem. Well, I must admit that only doing a tcpm_unregister_altmodes() should be harmless. > > thanks, > Kyle