From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Sebastian Reichel <sre@kernel.org>,
Hans de Goede <hdegoede@redhat.com>, Jun Li <jun.li@nxp.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Support Opensource <Support.Opensource@diasemi.com>
Subject: RE: [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS
Date: Mon, 23 Apr 2018 12:47:47 +0000 [thread overview]
Message-ID: <2E89032DDAA8B9408CB92943514A0337014C1E6D83@SW-EX-MBX01.diasemi.com> (raw)
In-Reply-To: <20180423112818.GA22932@kroah.com>
On 23 April 2018 12:28, Greg Kroah-Hartman wrote:
> On Mon, Apr 23, 2018 at 11:06:25AM +0000, Adam Thomson wrote:
> > On 23 April 2018 09:25, Greg Kroah-Hartman wrote:
> >
> > > On Mon, Apr 23, 2018 at 07:49:38AM +0000, Adam Thomson wrote:
> > > > On 22 April 2018 21:58, Adam Thomson wrote:
> > > >
> > > > > On 22 April 2018 15:05, Greg Kroah-Hartman wrote:
> > > > >
> > > > > > On Fri, Mar 23, 2018 at 10:12:20AM +0000, Adam Thomson wrote:
> > > > > > > This commit adds code to handle requesting of PPS APDOs. Switching
> > > > > > > between standard PDOs and APDOs, and re-requesting an APDO to
> > > > > > > modify operating voltage/current will be triggered by an
> > > > > > > external call into TCPM.
> > > > > > >
> > > > > > > Signed-off-by: Adam Thomson
> <Adam.Thomson.Opensource@diasemi.com>
> > > > > > > Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > > > > > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > > > > > > ---
> > > > > > > drivers/usb/typec/tcpm.c | 517
> > > > > > ++++++++++++++++++++++++++++++++++++++++++++++-
> > > > > > > include/linux/usb/pd.h | 4 +-
> > > > > > > include/linux/usb/tcpm.h | 1 +
> > > > > > > 3 files changed, 509 insertions(+), 13 deletions(-)
> > > > > >
> > > > > > This patch adds build warnings to the tree, so I can't take it, sorry.
> > > > > > Please fix up and resend.
> > > > >
> > > > > No problem. Sorry for that. Will take a look and resolve the warnings.
> > > >
> > > > Sadly this is going to be a bit more than 'resolve the warnings' task now as Jun
> > > > Li's patch set has now made it in before me which means I need to rebase PDO
> > > > Selection because of his changes. :(
> > >
> > > Someone was going to have to do that, sorry :(
> >
> > Just as an FYI, this patch will produce warnings until the associated
> > power_supply interface patch (number 5 in the series previously sent) is
> > included as that makes use of the new API. Not sure how I can get around that
> > so I guess we have to wait on Sebastian to give the nod for the rest of the
> > power_supply patches before this can make it through.
>
> That's not good. There has to be a way to prevent a build warning from
> happening...
If we're ok with '__maybe_unused' then I can add that. Wasn't sure if something
like that would be acceptable for this scenario.
next prev parent reply other threads:[~2018-04-23 12:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 10:12 [PATCH v7 0/6] typec: tcpm: Add sink side support for PPS Adam Thomson
2018-03-23 10:12 ` [PATCH v7 1/6] typec: tcpm: Add core support for sink side PPS Adam Thomson
2018-03-26 3:10 ` Guenter Roeck
2018-04-22 14:05 ` Greg Kroah-Hartman
2018-04-22 20:57 ` Adam Thomson
2018-04-23 7:49 ` Adam Thomson
2018-04-23 8:25 ` Greg Kroah-Hartman
2018-04-23 11:06 ` Adam Thomson
2018-04-23 11:28 ` Greg Kroah-Hartman
2018-04-23 12:47 ` Adam Thomson [this message]
2018-04-23 13:20 ` Greg Kroah-Hartman
2018-03-23 10:12 ` [PATCH v7 2/6] Documentation: power: Initial effort to document power_supply ABI Adam Thomson
2018-03-26 9:57 ` Greg Kroah-Hartman
2018-03-26 12:40 ` Adam Thomson
2018-03-26 12:50 ` Greg Kroah-Hartman
2018-03-23 10:12 ` [PATCH v7 3/6] power: supply: Add error checking of psy desc during registration Adam Thomson
2018-03-23 10:12 ` [PATCH v7 4/6] power: supply: Add 'usb_type' property and supporting code Adam Thomson
2018-03-23 10:12 ` [PATCH v7 5/6] typec: tcpm: Represent source supply through power_supply Adam Thomson
2018-03-26 3:14 ` Guenter Roeck
2018-03-23 10:12 ` [PATCH v7 6/6] typec: tcpm: Add support for sink PPS related messages Adam Thomson
2018-03-26 3:15 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2E89032DDAA8B9408CB92943514A0337014C1E6D83@SW-EX-MBX01.diasemi.com \
--to=adam.thomson.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).