linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>, <wangkefeng.wang@huawei.com>,
	<arnd@arndb.de>, <rafael@kernel.org>, <linux-pci@vger.kernel.org>,
	"Will Deacon" <will.deacon@arm.com>,
	<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
	<andy.shevchenko@gmail.com>,
	<linux-arm-kernel@lists.infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>, <bp@suse.de>,
	<linux@roeck-us.net>
Subject: Re: [RFC PATCH v2 1/3] resource: Request IO port regions from children of ioport_resource
Date: Tue, 2 Apr 2019 10:46:10 +0100	[thread overview]
Message-ID: <2b98fa8b-d12a-8d48-e47d-075d25c47bb2@huawei.com> (raw)
In-Reply-To: <20190329122206.GA28421@e107981-ln.cambridge.arm.com>

On 29/03/2019 12:22, Lorenzo Pieralisi wrote:
>>> > >Side note: these drivers can't be compiled on PPC, it would be
>>> > >good to understand why, I have a hunch it can be related.
>> >
>> > I mentioned this earlier:
>> >
>> > I saw that in commits like 746cdfbf01c0 ("hwmon: Avoid building drivers
>> > forpowerpc that read/write ISA addresses"), PPC would not build these
>> > drivers, as, like arm, it has no native ISA.
>> >
>> > However I still don't think just avoiding compiling these drivers for
>> > certain archs solves the problem.
> No it does not but I would like to understand how relevant is fixing
> those drivers (that should not use ISA IO space without first claiming
> their resources, for the records) given that PPC did not even try and
> apparently that's not a problem.
>

Hi Lorenzo,

Those drivers should still be fixed up separately.

The tricky part in this series is making the resource claim fail if 
there is no IO space mapped/accessible at the addresses requested.

However I would still like to fix up the low level IO port accessors to 
discard accesses when no IO space is mapped.

Thanks,
John

>> >
>> > [...]
>> >
>>>>>>> > >>>>>[1] https://www.spinics.net/lists/linux-pci



  reply	other threads:[~2019-04-02  9:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 18:14 [PATCH v2 0/3] Fix system crash for accessing unmapped IO port regions John Garry
2019-03-20 18:14 ` [RFC PATCH v2 1/3] resource: Request IO port regions from children of ioport_resource John Garry
2019-03-25 23:32   ` Bjorn Helgaas
2019-03-26 16:33     ` John Garry
2019-03-26 22:48       ` Bjorn Helgaas
2019-03-27 11:24         ` John Garry
2019-03-28 17:46         ` Lorenzo Pieralisi
2019-03-29 10:42           ` John Garry
2019-03-29 12:22             ` Lorenzo Pieralisi
2019-04-02  9:46               ` John Garry [this message]
2019-03-20 18:14 ` [PATCH v2 2/3] lib: logic_pio: Reject access to unregistered CPU MMIO regions John Garry
2019-03-23 19:15   ` Andy Shevchenko
2019-03-25  9:59     ` John Garry
2019-03-20 18:14 ` [PATCH v2 3/3] lib: logic_pio: Make some prints explicitly hex John Garry
2019-03-23 19:12   ` Andy Shevchenko
2019-03-25  9:48     ` John Garry
2019-03-25 15:03       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b98fa8b-d12a-8d48-e47d-075d25c47bb2@huawei.com \
    --to=john.garry@huawei.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bp@suse.de \
    --cc=catalin.marinas@arm.com \
    --cc=helgaas@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=linuxarm@huawei.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=rafael@kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).