From: Wenchao Hao <haowenchao22@gmail.com>
To: Wenchao Hao <haowenchao2@huawei.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/3] SCSI: Fix issues between removing device and error handle
Date: Fri, 12 Apr 2024 10:07:01 +0800 [thread overview]
Message-ID: <2c1a070d-7595-4a7b-a234-99e2c56d801f@gmail.com> (raw)
In-Reply-To: <20240307144311.73735-1-haowenchao2@huawei.com>
On 2024/3/7 22:43, Wenchao Hao wrote:
> I am testing SCSI error handle with my previous scsi_debug error
> injection patches, and found some issues when removing device and
> error handler happened together.
>
> These issues are triggered because devices in removing would be skipped
> when calling shost_for_each_device().
>
Friendly ping...
> The issues are found:
> 1. statistic info printed at beginning of scsi_error_handler is wrong
> 2. device reset is not triggered
>
> V4:
> - Remove the forth patch which fix IO hang when device removing
> becaust the issue is fixed by commit '6df0e077d76bd (scsi: core:
> Kick the requeue list after inserting when flushing)'
>
> V3:
> - Update patch description
> - Update comments of functions added
>
> V2:
> - Fix IO hang by run all devices' queue after error handler
> - Do not modify shost_for_each_device() directly but add a new
> helper to iterate devices but do not skip devices in removing
>
> Wenchao Hao (3):
> scsi: core: Add new helper to iterate all devices of host
> scsi: scsi_error: Fix wrong statistic when print error info
> scsi: scsi_error: Fix device reset is not triggered
>
> drivers/scsi/scsi.c | 46 ++++++++++++++++++++++++++------------
> drivers/scsi/scsi_error.c | 4 ++--
> include/scsi/scsi_device.h | 25 ++++++++++++++++++---
> 3 files changed, 56 insertions(+), 19 deletions(-)
>
next prev parent reply other threads:[~2024-04-12 2:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 14:43 [PATCH v4 0/3] SCSI: Fix issues between removing device and error handle Wenchao Hao
2024-03-07 14:43 ` [PATCH v4 1/3] scsi: core: Add new helper to iterate all devices of host Wenchao Hao
2024-03-07 14:43 ` [PATCH v4 2/3] scsi: scsi_error: Fix wrong statistic when print error info Wenchao Hao
2024-03-07 14:43 ` [PATCH v4 3/3] scsi: scsi_error: Fix device reset is not triggered Wenchao Hao
2024-03-26 6:37 ` [PATCH v4 0/3] SCSI: Fix issues between removing device and error handle Wenchao Hao
2024-04-12 2:07 ` Wenchao Hao [this message]
2024-04-15 15:07 ` Markus Elfring
2024-04-17 15:00 ` Wenchao Hao
2024-04-17 15:06 ` Julia Lawall
2024-04-17 15:18 ` Wenchao Hao
2024-04-17 15:29 ` Wenchao Hao
2024-04-17 15:48 ` [v4 " Markus Elfring
2024-04-17 16:39 ` Wenchao Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c1a070d-7595-4a7b-a234-99e2c56d801f@gmail.com \
--to=haowenchao22@gmail.com \
--cc=haowenchao2@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).