From: Hans de Goede <hdegoede@redhat.com>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tsuchiya Yuto <kitakar@gmail.com>,
Martiros Shakhzadyan <vrzh@vrzh.net>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, Ira Weiny <ira.weiny@intel.com>,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: media: atomisp: Use kmap_local_page() in hmm_store()
Date: Wed, 20 Apr 2022 13:07:16 +0200 [thread overview]
Message-ID: <2d096f20-dbaa-1d49-96e9-a7ae6c19f7fe@redhat.com> (raw)
In-Reply-To: <20220413225531.9425-1-fmdefrancesco@gmail.com>
Hi,
On 4/14/22 00:55, Fabio M. De Francesco wrote:
> The use of kmap() is being deprecated in favor of kmap_local_page()
> where it is feasible. The same is true for kmap_atomic().
>
> In file pci/hmm/hmm.c, function hmm_store() test if we are in atomic
> context and, if so, it calls kmap_atomic(), if not, it calls kmap().
>
> First of all, in_atomic() shouldn't be used in drivers. This macro
> cannot always detect atomic context; in particular, it cannot know
> about held spinlocks in non-preemptible kernels.
>
> Notwithstanding what it is said above, this code doesn't need to care
> whether or not it is executing in atomic context. It can simply use
> kmap_local_page() / kunmap_local() that can instead do the mapping /
> unmapping regardless of the context.
>
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible. Therefore, hmm_store()() is a function where the use
> of kmap_local_page() in place of both kmap() and kmap_atomic() is
> correctly suited.
>
> Convert the calls of kmap() / kunmap() and kmap_atomic() /
> kunmap_atomic() to kmap_local_page() / kunmap_local() and drop the
> unnecessary tests which test if the code is in atomic context.
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
I've successfully tested this on both the front and back cams
of a chuwi hi8 tablet:
Tested-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/media/atomisp/pci/hmm/hmm.c | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm.c b/drivers/staging/media/atomisp/pci/hmm/hmm.c
> index 46ac082cd3f1..54188197c3dc 100644
> --- a/drivers/staging/media/atomisp/pci/hmm/hmm.c
> +++ b/drivers/staging/media/atomisp/pci/hmm/hmm.c
> @@ -482,10 +482,7 @@ int hmm_store(ia_css_ptr virt, const void *data, unsigned int bytes)
> idx = (virt - bo->start) >> PAGE_SHIFT;
> offset = (virt - bo->start) - (idx << PAGE_SHIFT);
>
> - if (in_atomic())
> - des = (char *)kmap_atomic(bo->page_obj[idx].page);
> - else
> - des = (char *)kmap(bo->page_obj[idx].page);
> + des = (char *)kmap_local_page(bo->page_obj[idx].page);
>
> if (!des) {
> dev_err(atomisp_dev,
> @@ -512,14 +509,7 @@ int hmm_store(ia_css_ptr virt, const void *data, unsigned int bytes)
>
> clflush_cache_range(des, len);
>
> - if (in_atomic())
> - /*
> - * Note: kunmap_atomic requires return addr from
> - * kmap_atomic, not the page. See linux/highmem.h
> - */
> - kunmap_atomic(des - offset);
> - else
> - kunmap(bo->page_obj[idx].page);
> + kunmap_local(des);
> }
>
> return 0;
next prev parent reply other threads:[~2022-04-20 11:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 22:55 [PATCH] staging: media: atomisp: Use kmap_local_page() in hmm_store() Fabio M. De Francesco
2022-04-14 0:44 ` Alison Schofield
2022-04-14 1:54 ` Ira Weiny
2022-04-14 7:03 ` Julia Lawall
2022-04-14 9:03 ` Fabio M. De Francesco
2022-04-14 9:12 ` Julia Lawall
2022-04-14 9:41 ` Fabio M. De Francesco
2022-04-15 0:37 ` Ira Weiny
2022-04-15 1:08 ` Fabio M. De Francesco
2022-04-20 11:07 ` Hans de Goede [this message]
2022-04-25 18:29 ` Fabio M. De Francesco
2022-04-29 13:46 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d096f20-dbaa-1d49-96e9-a7ae6c19f7fe@redhat.com \
--to=hdegoede@redhat.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=ira.weiny@intel.com \
--cc=kitakar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy@lists.linux.dev \
--cc=sakari.ailus@linux.intel.com \
--cc=vrzh@vrzh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).