From: David Laight <David.Laight@ACULAB.COM>
To: 'Eugene Korenevsky' <ekorenevsky@gmail.com>
Cc: "kzak@redhat.com" <kzak@redhat.com>,
Davidlohr Bueso <dave@stgolabs.net>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: RE: [PATCH v2] efi: take size of partition entry from GPT header
Date: Fri, 14 Sep 2018 09:01:48 +0000 [thread overview]
Message-ID: <2db38b2d1af34ab9b653c665d08872f1@AcuMS.aculab.com> (raw)
In-Reply-To: <CAJC2YLaug4=7otnRC7x+UdDp=5ErgJFHFL_7mjRO7sdM2CrUfQ@mail.gmail.com>
From: Eugene Korenevsky
> Sent: 13 September 2018 20:48
>
> > I suspect you also need a sanity check that the value isn't too small
> > or stupidly large.
>
> What would be the criterion for too large entries?
Anything larger than the maximum size of the full GPT table
would be a start.
Even something like 64k would stop later calculations going wrong.
I presume there is a check elsewhere that the GPT table entries
are all inside the disk area that was read?
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2018-09-14 8:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 16:15 [PATCH v2] efi: take size of partition entry from GPT header Eugene Korenevsky
2018-09-11 16:27 ` Davidlohr Bueso
2018-09-11 16:42 ` Eugene Korenevsky
2018-09-11 22:56 ` kbuild test robot
2018-09-11 22:59 ` Ard Biesheuvel
2018-09-11 23:20 ` kbuild test robot
2018-09-12 8:38 ` Karel Zak
2018-09-13 13:06 ` David Laight
2018-09-13 19:48 ` Eugene Korenevsky
2018-09-14 9:01 ` David Laight [this message]
2018-09-14 11:07 ` kzak
2018-10-06 18:41 ` Eugene Korenevsky
2018-10-08 11:15 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2db38b2d1af34ab9b653c665d08872f1@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=ard.biesheuvel@linaro.org \
--cc=dave@stgolabs.net \
--cc=ekorenevsky@gmail.com \
--cc=kzak@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).