From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Jonathan Corbet <corbet@lwn.net>, Joe Perches <joe@perches.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Jason Baron <jbaron@akamai.com>,
Stefani Seibold <stefani@seibold.net>,
Jacob Keller <jacob.e.keller@intel.com>,
Thomas Graf <tgraf@suug.ch>,
Herbert Xu <herbert@gondor.apana.org.au>,
Jens Axboe <axboe@kernel.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] scripts: add spelling_sanitizer.sh script
Date: Fri, 18 Jun 2021 10:51:14 +0800 [thread overview]
Message-ID: <2dd756b6-a02b-0bad-4161-1b3dbc223d84@huawei.com> (raw)
In-Reply-To: <YMr6nv1G+bq235nR@alley>
On 2021/6/17 15:32, Petr Mladek wrote:
> On Thu 2021-06-17 09:11:05, Leizhen (ThunderTown) wrote:
>>
>>
>> On 2021/6/16 22:53, Jonathan Corbet wrote:
>>> Zhen Lei <thunder.leizhen@huawei.com> writes:
>>>
>>>> The file scripts/spelling.txt recorded a large number of spelling
>>>> "mistake||correction" pairs. These entries are currently maintained in
>>>> order, but the results are not strict. In addition, when someone wants to
>>>> add some new pairs, he either sort them manually or write a script, which
>>>> is clearly a waste of labor. So add this script. For all spelling
>>>> "mistake||correction" pairs, sort based on "correction", then on "mistake",
>>>> and remove duplicates. Sorting based on "mistake" first is not chosen
>>>> because it is uncontrollable.
>>>>
>>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>>> ---
>>>> scripts/spelling_sanitizer.sh | 27 +++++++++++++++++++++++++++
>>>> 1 file changed, 27 insertions(+)
>>>> create mode 100755 scripts/spelling_sanitizer.sh
>>>>
>>>> diff --git a/scripts/spelling_sanitizer.sh b/scripts/spelling_sanitizer.sh
>>>> new file mode 100755
>>>> index 000000000000..603bb7e0e66b
>>>> --- /dev/null
>>>> +++ b/scripts/spelling_sanitizer.sh
>>>> @@ -0,0 +1,27 @@
>>>> +#!/bin/sh -efu
>>>> +# SPDX-License-Identifier: GPL-2.0
>>>> +
>>>> +# To get the traditional sort order that uses native byte values
>>>
>>> So I am of the naive opinion that everything we drop into scripts/
>>> should start with a comment saying why it exists and how to use it.
>>> Otherwise how are people going to benefit from it?
>>
>> Rigth, I will add the description, thanks.
>
> Ideally, please add also some -h/--help option that would print a short
> description and usage.
OK, I will add it.
>
> Best Regards,
> Petr
>
> .
>
next prev parent reply other threads:[~2021-06-18 2:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 12:25 [PATCH v2 0/3] scripts/spelling.txt: add some spelling pairs and reorder Zhen Lei
2021-06-16 12:25 ` [PATCH v2 1/3] scripts: add spelling_sanitizer.sh script Zhen Lei
2021-06-16 14:53 ` Jonathan Corbet
2021-06-17 1:11 ` Leizhen (ThunderTown)
2021-06-17 7:32 ` Petr Mladek
2021-06-18 2:51 ` Leizhen (ThunderTown) [this message]
2021-06-16 12:25 ` [PATCH v2 2/3] scripts/spelling.txt: sort and remove duplicates Zhen Lei
2021-06-16 12:25 ` [PATCH v2 3/3] scripts/spelling.txt: add some spelling "mistake||correction" pairs Zhen Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dd756b6-a02b-0bad-4161-1b3dbc223d84@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=herbert@gondor.apana.org.au \
--cc=jacob.e.keller@intel.com \
--cc=jbaron@akamai.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=nicolas.dichtel@6wind.com \
--cc=pmladek@suse.com \
--cc=senozhatsky@chromium.org \
--cc=stefani@seibold.net \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).