linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: cgel.zte@gmail.com, chris.hyser@oracle.com
Cc: shuah@kernel.org, yong.yiran@zte.com.cn,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zeal Robot <zealci@zte.com.cn>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH linux-next] kselftest: remove duplicate include in cs_prctl_test.c
Date: Tue, 24 Aug 2021 08:40:09 -0600	[thread overview]
Message-ID: <2f864600-76ca-6d05-64d4-990fd915c509@linuxfoundation.org> (raw)
In-Reply-To: <20210805061919.627607-1-yong.yiran@zte.com.cn>

On 8/5/21 12:19 AM, cgel.zte@gmail.com wrote:
> From: yong yiran <yong.yiran@zte.com.cn>
> 
> 'sys/types.h' included in 'cs_prctl_test.c' is duplicated.
> Remove all but the first include of sys/types.h from cs_prctl_test.c.
> 
> 'sys/wait.h' include in 'cs_prctl_test.c' is duplicated.
> Remove all but the first include of sys/wait.h from cs_prctl_test.c.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: yong yiran <yong.yiran@zte.com.cn>
> ---
>   tools/testing/selftests/sched/cs_prctl_test.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/sched/cs_prctl_test.c b/tools/testing/selftests/sched/cs_prctl_test.c
> index 63fe6521c56d..7db9cf822dc7 100644
> --- a/tools/testing/selftests/sched/cs_prctl_test.c
> +++ b/tools/testing/selftests/sched/cs_prctl_test.c
> @@ -25,8 +25,6 @@
>   #include <sys/types.h>
>   #include <sched.h>
>   #include <sys/prctl.h>
> -#include <sys/types.h>
> -#include <sys/wait.h>
>   #include <unistd.h>
>   #include <time.h>
>   #include <stdio.h>
> 

We can't accept this patch. The from and Signed-off-by don't match.

thanks,
-- Shuah

      reply	other threads:[~2021-08-24 14:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05  6:19 [PATCH linux-next] kselftest: remove duplicate include in cs_prctl_test.c cgel.zte
2021-08-24 14:40 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f864600-76ca-6d05-64d4-990fd915c509@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=cgel.zte@gmail.com \
    --cc=chris.hyser@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=yong.yiran@zte.com.cn \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).