From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Subject: Re: [PATCH 3/4] mtd: mchp23k256: add partitioning support
Date: Mon, 22 May 2017 04:52:34 +0000 [thread overview]
Message-ID: <31c94577108c42c1b51d410081d97eb5@svr-chch-ex1.atlnz.lc> (raw)
In-Reply-To: 20170517172911.5f926712@bbrezillon
On 18/05/17 03:29, Boris Brezillon wrote:
> Hi Chris,
>
> On Wed, 17 May 2017 17:39:07 +1200
> Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
>
>> Setting the of_node for the mtd device allows the generic mtd code to
>> setup the partitions. Additionally we must specify a non-zero erasesize
>> for the partitions to be writeable.
>>
>> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>> ---
>> drivers/mtd/devices/mchp23k256.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/mtd/devices/mchp23k256.c b/drivers/mtd/devices/mchp23k256.c
>> index 2542f5b8b63f..02c6b9dcbd3e 100644
>> --- a/drivers/mtd/devices/mchp23k256.c
>> +++ b/drivers/mtd/devices/mchp23k256.c
>> @@ -143,6 +143,7 @@ static int mchp23k256_probe(struct spi_device *spi)
>>
>> data = dev_get_platdata(&spi->dev);
>>
>> + mtd_set_of_node(&flash->mtd, spi->dev.of_node);
>> flash->mtd.dev.parent = &spi->dev;
>> flash->mtd.type = MTD_RAM;
>> flash->mtd.flags = MTD_CAP_RAM;
>> @@ -151,6 +152,10 @@ static int mchp23k256_probe(struct spi_device *spi)
>> flash->mtd._read = mchp23k256_read;
>> flash->mtd._write = mchp23k256_write;
>>
>> + flash->mtd.erasesize = PAGE_SIZE;
>> + while (flash->mtd.size & (flash->mtd.erasesize - 1))
>> + flash->mtd.erasesize >>= 1;
>> +
>
> Can we fix allocate_partition() to properly handle the
> master->erasesize == 0 case instead of doing that?
>
Do you mean something like this?
diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index ea5e5307f667..0cd20ed6b374 100644
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -577,6 +577,7 @@ static struct mtd_part *allocate_partition(struct
mtd_info *master,
part->name);
}
if ((slave->mtd.flags & MTD_WRITEABLE) &&
+ master->erasesize != 0 &&
mtd_mod_by_eb(slave->mtd.size, &slave->mtd)) {
slave->mtd.flags &= ~MTD_WRITEABLE;
I'm happy to submit this as a formal patch but it could potentially
affect a number of devices. Whereas the snippet I initially added is
consistent with drivers/mtd/chips/map_ram.c.
For now I'll leave v2 as-is but I can send a v3 if needed.
next prev parent reply other threads:[~2017-05-22 4:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 5:39 [PATCH 0/4] mtd: mchp23k256: device tree and mchp23lcv1024 Chris Packham
2017-05-17 5:39 ` [PATCH 1/4] mtd: mchp23k256: Add OF device ID table Chris Packham
2017-05-17 11:44 ` Andrew Lunn
2017-05-17 5:39 ` [PATCH 2/4] mtd: mchp23k256: switch to mtd_device_register() Chris Packham
2017-05-17 11:48 ` Andrew Lunn
2017-05-17 5:39 ` [PATCH 3/4] mtd: mchp23k256: add partitioning support Chris Packham
2017-05-17 14:18 ` Andrew Lunn
2017-05-17 15:29 ` Boris Brezillon
2017-05-22 4:52 ` Chris Packham [this message]
2017-05-22 7:38 ` Boris Brezillon
2017-06-01 18:43 ` Brian Norris
2017-06-01 20:47 ` Boris Brezillon
2017-06-01 22:01 ` Brian Norris
2017-06-02 9:04 ` Boris Brezillon
2017-06-08 23:21 ` Brian Norris
2017-06-01 21:30 ` Chris Packham
2017-06-01 22:23 ` Brian Norris
2017-06-01 23:08 ` Chris Packham
2017-06-08 23:18 ` Brian Norris
2017-05-17 5:39 ` [PATCH 4/4] mtd: mchp23k256: Add support for mchp23lcv1024 Chris Packham
2017-05-17 12:17 ` Andrew Lunn
2017-05-18 4:36 ` Chris Packham
2017-05-17 11:41 ` [PATCH 0/4] mtd: mchp23k256: device tree and mchp23lcv1024 Andrew Lunn
2017-05-17 14:19 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31c94577108c42c1b51d410081d97eb5@svr-chch-ex1.atlnz.lc \
--to=chris.packham@alliedtelesis.co.nz \
--cc=andrew@lunn.ch \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).