From: Michael Walle <michael@walle.cc>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 1/1] mfd: simple-mfd-i2c: Add support for registering devices via MFD cells
Date: Thu, 05 Aug 2021 09:05:57 +0200 [thread overview]
Message-ID: <328e69d4d6d57b101af1ab1346b0809f@walle.cc> (raw)
In-Reply-To: <20210804143744.689238-1-lee.jones@linaro.org>
Hi Lee,
Am 2021-08-04 16:37, schrieb Lee Jones:
> More devices are cropping up requiring only Regmap initialisation and
> child registration functionality. We currently only support that if
> all required devices are represented by their own Device Tree nodes
> complete with compatible strings.
>
> However, not everyone is happy with adding empty nodes that provide no
> additional device information into the Device Tree.
>
> Rather than have a plethora of mostly empty, function-less drivers in
> MFD, we'll support those simple cases in here instead via MFD cells.
>
> Cc: Michael Walle <michael@walle.cc>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>
> Michael, could you please test this on your platform to ensure I
> didn't break anything please?
>
I'm getting a null pointer dereference.
[..]
> static int simple_mfd_i2c_probe(struct i2c_client *i2c)
> {
> - const struct regmap_config *config;
> + const struct simple_mfd_data *simple_mfd_data;
> + const struct regmap_config *regmap_config;
> struct regmap *regmap;
> + int ret;
> +
> + simple_mfd_data = device_get_match_data(&i2c->dev);
>
> - config = device_get_match_data(&i2c->dev);
> - if (!config)
> - config = &simple_regmap_config;
> + if (simple_mfd_data->regmap_config)
simple_mfd_data might be NULL.
> + regmap_config = simple_mfd_data->regmap_config;
> + else
> + regmap_config = ®map_config_8r_8v;
>
> - regmap = devm_regmap_init_i2c(i2c, config);
> + regmap = devm_regmap_init_i2c(i2c, regmap_config);
> if (IS_ERR(regmap))
> return PTR_ERR(regmap);
>
> - return devm_of_platform_populate(&i2c->dev);
> + if (!simple_mfd_data->mfd_cell)
likewise
> + return devm_of_platform_populate(&i2c->dev);
> +
> + ret = devm_mfd_add_devices(&i2c->dev, PLATFORM_DEVID_AUTO,
> + simple_mfd_data->mfd_cell,
> + simple_mfd_data->mfd_cell_size,
> + NULL, 0, NULL);
> + if (!ret)
> + dev_err(&i2c->dev, "Failed to add child devices\n");
> +
> + return ret;
> }
-michael
next prev parent reply other threads:[~2021-08-05 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 14:37 [PATCH 1/1] mfd: simple-mfd-i2c: Add support for registering devices via MFD cells Lee Jones
2021-08-05 7:05 ` Michael Walle [this message]
2021-08-05 7:40 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=328e69d4d6d57b101af1ab1346b0809f@walle.cc \
--to=michael@walle.cc \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).