From: Pavel Begunkov <asml.silence@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Matthew Wilcox <willy@infradead.org>,
Ming Lei <ming.lei@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 1/7] splice: don't generate zero-len segement bvecs
Date: Mon, 4 Jan 2021 16:54:42 +0000 [thread overview]
Message-ID: <333a7628-904b-c02a-b871-298b4833974a@gmail.com> (raw)
In-Reply-To: <20210104161716.GA68600@infradead.org>
On 04/01/2021 16:17, Christoph Hellwig wrote:
> On Sat, Jan 02, 2021 at 03:17:33PM +0000, Pavel Begunkov wrote:
>> iter_file_splice_write() may spawn bvec segments with zero-length. In
>> preparation for prohibiting them, filter out by hand at splice level.
>>
>> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
>> ---
>> fs/splice.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/fs/splice.c b/fs/splice.c
>> index 866d5c2367b2..7299330c3270 100644
>> --- a/fs/splice.c
>> +++ b/fs/splice.c
>> @@ -644,7 +644,6 @@ iter_file_splice_write(struct pipe_inode_info *pipe, struct file *out,
>> ret = splice_from_pipe_next(pipe, &sd);
>> if (ret <= 0)
>> break;
>> -
>
> Spurious empty line removal..
>
>> + if (!this_len)
>> + continue;
>
> Maybe throw in a comment on why we skip empty segments here?
Definitely won't hurt. Thanks for taking a look
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
--
Pavel Begunkov
next prev parent reply other threads:[~2021-01-04 16:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 15:17 [PATCH v2 0/7] no-copy bvec Pavel Begunkov
2021-01-02 15:17 ` [PATCH v2 1/7] splice: don't generate zero-len segement bvecs Pavel Begunkov
2021-01-04 16:17 ` Christoph Hellwig
2021-01-04 16:54 ` Pavel Begunkov [this message]
2021-01-02 15:17 ` [PATCH v2 2/7] bvec/iter: disallow zero-length segment bvecs Pavel Begunkov
2021-01-04 16:18 ` Christoph Hellwig
2021-01-04 16:37 ` Matthew Wilcox
2021-01-04 17:23 ` Pavel Begunkov
2021-01-02 15:17 ` [PATCH v2 3/7] block/psi: remove PSI annotations from direct IO Pavel Begunkov
2021-01-04 16:45 ` Christoph Hellwig
2021-01-02 15:17 ` [PATCH v2 4/7] target/file: allocate the bvec array as part of struct target_core_file_cmd Pavel Begunkov
2021-01-02 15:17 ` [PATCH v2 5/7] iov_iter: optimise bvec iov_iter_advance() Pavel Begunkov
2021-01-02 15:17 ` [PATCH v2 6/7] bio: add a helper calculating nr segments to alloc Pavel Begunkov
2021-01-02 15:17 ` [PATCH v2 7/7] bio: don't copy bvec for direct IO Pavel Begunkov
2021-01-04 16:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=333a7628-904b-c02a-b871-298b4833974a@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=darrick.wong@oracle.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=target-devel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).