From: Vlastimil Babka <vbabka@suse.cz>
To: Yang Shi <yang.shi@linux.alibaba.com>,
mhocko@kernel.org, kirill@shutemov.name, willy@infradead.org,
ldufour@linux.vnet.ibm.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH 2/2 -mm] mm: brk: dwongrade mmap_sem to read when shrinking
Date: Thu, 27 Sep 2018 14:14:00 +0200 [thread overview]
Message-ID: <33d52132-546f-3c8a-3445-cdbc9068589a@suse.cz> (raw)
In-Reply-To: <1537985434-22655-2-git-send-email-yang.shi@linux.alibaba.com>
On 9/26/18 8:10 PM, Yang Shi wrote:
Again, "downgrade" in the subject
> brk might be used to shinrk memory mapping too other than munmap().
^ shrink
> So, it may hold write mmap_sem for long time when shrinking large
> mapping, as what commit ("mm: mmap: zap pages with read mmap_sem in
> munmap") described.
>
> The brk() will not manipulate vmas anymore after __do_munmap() call for
> the mapping shrink use case. But, it may set mm->brk after
> __do_munmap(), which needs hold write mmap_sem.
>
> However, a simple trick can workaround this by setting mm->brk before
> __do_munmap(). Then restore the original value if __do_munmap() fails.
> With this trick, it is safe to downgrade to read mmap_sem.
>
> So, the same optimization, which downgrades mmap_sem to read for
> zapping pages, is also feasible and reasonable to this case.
>
> The period of holding exclusive mmap_sem for shrinking large mapping
> would be reduced significantly with this optimization.
>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Kirill A. Shutemov <kirill@shutemov.name>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Laurent Dufour <ldufour@linux.vnet.ibm.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Yang Shi <yang.shi@linux.alibaba.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Same nit for the "bool downgrade" name as for patch 1/2.
Thanks,
Vlastimil
next prev parent reply other threads:[~2018-09-27 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 18:10 [v2 PATCH 1/2 -mm] mm: mremap: dwongrade mmap_sem to read when shrinking Yang Shi
2018-09-26 18:10 ` [v2 PATCH 2/2 -mm] mm: brk: " Yang Shi
2018-09-27 12:14 ` Vlastimil Babka [this message]
2018-09-27 16:05 ` Yang Shi
2018-09-27 12:50 ` Kirill A. Shutemov
2018-09-27 13:21 ` Vlastimil Babka
2018-09-27 16:06 ` Yang Shi
2018-09-27 11:50 ` [v2 PATCH 1/2 -mm] mm: mremap: " Vlastimil Babka
2018-09-27 16:04 ` Yang Shi
2018-09-27 12:46 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33d52132-546f-3c8a-3445-cdbc9068589a@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).