From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Tejun Heo <tj@kernel.org>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-ide@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/3] SATA: Fine-tuning for two function implementations
Date: Thu, 11 May 2017 17:01:34 +0200 [thread overview]
Message-ID: <3428511.iH6kg31xz3@amdc3058> (raw)
In-Reply-To: <20170428215334.GH22354@htj.duckdns.org>
Hi,
On Friday, April 28, 2017 05:53:34 PM Tejun Heo wrote:
> Hello,
>
> On Tue, Apr 18, 2017 at 10:00:37PM +0200, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Tue, 18 Apr 2017 21:54:32 +0200
> >
> > A few update suggestions were taken into account
> > from static source code analysis.
>
> Hmmm, allocs -> callocs. Are these actually beneficial? If so, why?
> Because one multiplication is rolled into the call?
Each conversion (i.e. I tried the one from patch #1) seems to add
an extra 24 bytes to the resulting code size (using gcc 4.8.4 for
ARM32 cross-compilation) so I don't see much point in the automatic
conversions. Only instances containing size calculations with
real possibility for integer overflows should be converted and
the patchset under discussion contains no such instances.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
prev parent reply other threads:[~2017-05-11 15:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 20:00 [PATCH 0/3] SATA: Fine-tuning for two function implementations SF Markus Elfring
2017-04-18 20:01 ` [PATCH 1/3] ata: libahci: Use kcalloc() in ahci_platform_get_resources() SF Markus Elfring
2017-04-18 20:02 ` [PATCH 2/3] ata: libahci: Use devm_kcalloc() " SF Markus Elfring
2017-04-18 20:03 ` [PATCH 3/3] sata_mv: Use devm_kcalloc() in mv_platform_probe() SF Markus Elfring
2017-04-28 21:53 ` [PATCH 0/3] SATA: Fine-tuning for two function implementations Tejun Heo
2017-04-29 8:30 ` SF Markus Elfring
[not found] ` <CGME20170511150136epcas5p4549f5ae51303ef506c0f7f91b5dd1317@epcas5p4.samsung.com>
2017-05-11 15:01 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3428511.iH6kg31xz3@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=elfring@users.sourceforge.net \
--cc=hdegoede@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).