From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: linux-sunxi@googlegroups.com, maxime.ripard@bootlin.com
Cc: hans.verkuil@cisco.com, acourbot@chromium.org,
sakari.ailus@linux.intel.com,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
tfiga@chromium.org, posciak@chromium.org,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, nicolas.dufresne@collabora.com,
jenskuske@gmail.com, jonas@kwiboo.se, ezequiel@collabora.com,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [linux-sunxi] [PATCH v3 2/2] media: cedrus: Add H264 decoding support
Date: Tue, 12 Feb 2019 18:46:38 +0100 [thread overview]
Message-ID: <3572175.7W1cnfb8sa@jernej-laptop> (raw)
In-Reply-To: <20190212104314.slytpbufwhf5ujv7@flea>
Dne torek, 12. februar 2019 ob 11:43:14 CET je Maxime Ripard napisal(a):
> Hi,
>
> On Mon, Feb 11, 2019 at 08:21:31PM +0100, Jernej Škrabec wrote:
> > > + reg = 0;
> > > + /*
> > > + * FIXME: This bit tells the video engine to use the default
> > > + * quantization matrices. This will obviously need to be
> > > + * changed to support the profiles supporting custom
> > > + * quantization matrices.
> > > + */
> > > + reg |= VE_H264_SHS_QP_SCALING_MATRIX_DEFAULT;
> >
> > This flag should not be needed anymore. From what I see, you correctly set
> > scaling matrix every time.
>
> The scaling matrix control is optional, so I guess we should protect
> that by a check on whether that control has been set or not. What do
> you think?
Is it? Consider following snippet from your patch:
<snip>
{
.id = V4L2_CID_MPEG_VIDEO_H264_SCALING_MATRIX,
.elem_size = sizeof(struct v4l2_ctrl_h264_scaling_matrix),
.codec = CEDRUS_CODEC_H264,
.required = true,
},
<snip>
Doesn't "required = true" mean that it's mandatory? But yes, if it's optional,
then you should add a check.
Best regards,
Jernej
next prev parent reply other threads:[~2019-02-12 17:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 14:39 [PATCH v3 0/2] media: cedrus: Add H264 decoding support Maxime Ripard
2019-02-11 14:39 ` [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls Maxime Ripard
2019-02-11 15:16 ` Hans Verkuil
2019-02-11 15:21 ` Hans Verkuil
2019-02-12 13:05 ` Maxime Ripard
2019-02-12 21:17 ` Ezequiel Garcia
2019-02-11 17:16 ` Nicolas Dufresne
2019-02-11 17:12 ` Ezequiel Garcia
2019-02-12 10:23 ` Maxime Ripard
2019-02-11 19:53 ` Ezequiel Garcia
2019-02-11 14:39 ` [PATCH v3 2/2] media: cedrus: Add H264 decoding support Maxime Ripard
2019-02-11 19:21 ` [linux-sunxi] " Jernej Škrabec
2019-02-12 10:43 ` Maxime Ripard
2019-02-12 17:46 ` Jernej Škrabec [this message]
2019-02-11 19:48 ` Ezequiel Garcia
2019-02-12 12:47 ` Maxime Ripard
2019-02-12 17:40 ` Jernej Škrabec
2019-02-14 20:42 ` Jernej Škrabec
2019-02-14 21:27 ` Jernej Škrabec
2019-02-12 12:50 ` [PATCH v3 0/2] " Tomasz Figa
2019-02-12 21:22 ` Ezequiel Garcia
2019-02-13 3:02 ` Tomasz Figa
2019-02-13 16:28 ` Ezequiel Garcia
2019-02-14 15:47 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3572175.7W1cnfb8sa@jernej-laptop \
--to=jernej.skrabec@gmail.com \
--cc=acourbot@chromium.org \
--cc=ezequiel@collabora.com \
--cc=hans.verkuil@cisco.com \
--cc=jenskuske@gmail.com \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@bootlin.com \
--cc=nicolas.dufresne@collabora.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=posciak@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).