From: Vlastimil Babka <vbabka@suse.cz>
To: Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@suse.de>, NeilBrown <neilb@suse.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 6/6] mm, migration: do not trigger OOM killer when migrating memory
Date: Mon, 26 Jun 2017 14:13:44 +0200 [thread overview]
Message-ID: <35aecfe6-4ef0-5d7f-cda0-fbe68cf356dc@suse.cz> (raw)
In-Reply-To: <20170623085345.11304-7-mhocko@kernel.org>
On 06/23/2017 10:53 AM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> Page migration (for memory hotplug, soft_offline_page or mbind) needs
> to allocate a new memory. This can trigger an oom killer if the target
> memory is depleated. Although quite unlikely, still possible, especially
> for the memory hotplug (offlining of memoery). Up to now we didn't
> really have reasonable means to back off. __GFP_NORETRY can fail just
> too easily and __GFP_THISNODE sticks to a single node and that is not
> suitable for all callers.
>
> But now that we have __GFP_RETRY_MAYFAIL we should use it. It is
> preferable to fail the migration than disrupt the system by killing some
> processes.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> include/linux/migrate.h | 2 +-
> mm/memory-failure.c | 3 ++-
> mm/mempolicy.c | 3 ++-
> 3 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/migrate.h b/include/linux/migrate.h
> index f80c9882403a..9f5885dae80e 100644
> --- a/include/linux/migrate.h
> +++ b/include/linux/migrate.h
> @@ -34,7 +34,7 @@ extern char *migrate_reason_names[MR_TYPES];
> static inline struct page *new_page_nodemask(struct page *page, int preferred_nid,
> nodemask_t *nodemask)
> {
> - gfp_t gfp_mask = GFP_USER | __GFP_MOVABLE;
> + gfp_t gfp_mask = GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL;
>
> if (PageHuge(page))
> return alloc_huge_page_nodemask(page_hstate(compound_head(page)),
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index e2e0cb0e1d0f..fe0c484c6fdb 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1492,7 +1492,8 @@ static struct page *new_page(struct page *p, unsigned long private, int **x)
>
> return alloc_huge_page_node(hstate, nid);
> } else {
> - return __alloc_pages_node(nid, GFP_HIGHUSER_MOVABLE, 0);
> + return __alloc_pages_node(nid,
> + GFP_HIGHUSER_MOVABLE | __GFP_RETRY_MAYFAIL, 0);
> }
> }
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 7d8e56214ac0..d911fa5cb2a7 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -1078,7 +1078,8 @@ static struct page *new_page(struct page *page, unsigned long start, int **x)
> /*
> * if !vma, alloc_page_vma() will use task or system default policy
> */
> - return alloc_page_vma(GFP_HIGHUSER_MOVABLE, vma, address);
> + return alloc_page_vma(GFP_HIGHUSER_MOVABLE | __GFP_RETRY_MAYFAIL,
> + vma, address);
> }
> #else
>
>
prev parent reply other threads:[~2017-06-26 12:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 8:53 [PATCH 0/6] mm: give __GFP_REPEAT a better semantic Michal Hocko
2017-06-23 8:53 ` [PATCH 1/6] MIPS: do not use __GFP_REPEAT for order-0 request Michal Hocko
2017-06-23 10:27 ` Ralf Baechle
2017-06-26 9:36 ` Vlastimil Babka
2017-06-23 8:53 ` [PATCH 2/6] mm, tree wide: replace __GFP_REPEAT by __GFP_RETRY_MAYFAIL with more useful semantic Michal Hocko
2017-06-26 11:45 ` Vlastimil Babka
2017-06-26 12:14 ` Michal Hocko
2017-06-26 12:17 ` Vlastimil Babka
2017-06-26 12:38 ` Michal Hocko
2017-06-26 12:42 ` Michal Hocko
2017-06-26 11:53 ` Vlastimil Babka
2017-06-23 8:53 ` [PATCH 3/6] xfs: map KM_MAYFAIL to __GFP_RETRY_MAYFAIL Michal Hocko
2017-06-27 8:49 ` Michal Hocko
2017-06-27 13:47 ` Christoph Hellwig
2017-06-27 14:06 ` Michal Hocko
2017-06-28 4:12 ` Darrick J. Wong
2017-06-23 8:53 ` [PATCH 4/6] mm: kvmalloc support __GFP_RETRY_MAYFAIL for all sizes Michal Hocko
2017-06-26 12:00 ` Vlastimil Babka
2017-06-26 12:18 ` Michal Hocko
2017-06-23 8:53 ` [PATCH 5/6] drm/i915: use __GFP_RETRY_MAYFAIL Michal Hocko
2017-06-23 8:53 ` [PATCH 6/6] mm, migration: do not trigger OOM killer when migrating memory Michal Hocko
2017-06-23 20:43 ` Andrew Morton
2017-06-26 5:28 ` Michal Hocko
2017-06-26 12:13 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35aecfe6-4ef0-5d7f-cda0-fbe68cf356dc@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).