From: Juergen Gross <jgross@suse.com>
To: Arun KS <arunks@codeaurora.org>,
kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, boris.ostrovsky@oracle.com,
akpm@linux-foundation.org, dan.j.williams@intel.com,
mhocko@suse.com, vbabka@suse.cz, iamjoonsoo.kim@lge.com,
gregkh@linuxfoundation.org, osalvador@suse.de, malat@debian.org,
kirill.shutemov@linux.intel.com, jrdr.linux@gmail.com,
yasu.isimatu@gmail.com, mgorman@techsingularity.net,
aaron.lu@intel.com, devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
xen-devel@lists.xenproject.org
Cc: vatsa@codeaurora.org, vinmenon@codeaurora.org, getarunks@gmail.com
Subject: Re: [PATCH v3] memory_hotplug: Free pages as higher order
Date: Thu, 27 Sep 2018 09:11:06 +0200 [thread overview]
Message-ID: <36488c0e-6bae-e277-2cdb-32d0dcc40065@suse.com> (raw)
In-Reply-To: <1538031530-25489-1-git-send-email-arunks@codeaurora.org>
On 27/09/18 08:58, Arun KS wrote:
> When free pages are done with higher order, time spend on
> coalescing pages by buddy allocator can be reduced. With
> section size of 256MB, hot add latency of a single section
> shows improvement from 50-60 ms to less than 1 ms, hence
> improving the hot add latency by 60%.
>
> Modify external providers of online callback to align with
> the change.
>
> Signed-off-by: Arun KS <arunks@codeaurora.org>
> ---
> Changes since v2:
> reuse code from __free_pages_boot_core()
>
> Changes since v1:
> - Removed prefetch()
>
> Changes since RFC:
> - Rebase.
> - As suggested by Michal Hocko remove pages_per_block.
> - Modifed external providers of online_page_callback.
>
> v2: https://lore.kernel.org/patchwork/patch/991363/
> v1: https://lore.kernel.org/patchwork/patch/989445/
> RFC: https://lore.kernel.org/patchwork/patch/984754/
>
> ---
> drivers/hv/hv_balloon.c | 6 ++++--
> drivers/xen/balloon.c | 18 ++++++++++++++---
> include/linux/memory_hotplug.h | 2 +-
> mm/internal.h | 1 +
> mm/memory_hotplug.c | 44 ++++++++++++++++++++++++++++++------------
> mm/page_alloc.c | 2 +-
> 6 files changed, 54 insertions(+), 19 deletions(-)
>
...
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index e12bb25..010cf4d 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -390,8 +390,8 @@ static enum bp_state reserve_additional_memory(void)
>
> /*
> * add_memory_resource() will call online_pages() which in its turn
> - * will call xen_online_page() callback causing deadlock if we don't
> - * release balloon_mutex here. Unlocking here is safe because the
> + * will call xen_bring_pgs_online() callback causing deadlock if we
> + * don't release balloon_mutex here. Unlocking here is safe because the
> * callers drop the mutex before trying again.
> */
> mutex_unlock(&balloon_mutex);
> @@ -422,6 +422,18 @@ static void xen_online_page(struct page *page)
> mutex_unlock(&balloon_mutex);
> }
>
> +static int xen_bring_pgs_online(struct page *pg, unsigned int order)
> +{
> + unsigned long i, size = (1 << order);
> + unsigned long start_pfn = page_to_pfn(pg);
> +
> + pr_debug("Online %lu pages starting at pfn 0x%lx\n", size, start_pfn);
> + for (i = 0; i < size; i++)
> + xen_online_page(pfn_to_page(start_pfn + i));
xen_online_page() isn't very complex and this is the only user.
Why don't you move its body in here and drop the extra function?
And now you can execute the loop with balloon_mutex held instead of
taking and releasing it in each iteration of the loop.
Juergen
next prev parent reply other threads:[~2018-09-27 7:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 6:58 [PATCH v3] memory_hotplug: Free pages as higher order Arun KS
2018-09-27 7:09 ` Oscar Salvador
2018-09-27 8:09 ` Arun KS
2018-09-27 7:11 ` Juergen Gross [this message]
2018-09-27 8:11 ` Arun KS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36488c0e-6bae-e277-2cdb-32d0dcc40065@suse.com \
--to=jgross@suse.com \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=arunks@codeaurora.org \
--cc=boris.ostrovsky@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=devel@linuxdriverproject.org \
--cc=getarunks@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jrdr.linux@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=malat@debian.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=sthemmin@microsoft.com \
--cc=vatsa@codeaurora.org \
--cc=vbabka@suse.cz \
--cc=vinmenon@codeaurora.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).