From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
dri-devel@lists.freedesktop.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v2] software node: Implement device_get_match_data fwnode callback
Date: Wed, 24 Apr 2024 18:51:47 +0800 [thread overview]
Message-ID: <365445ed-8f1d-4c05-90a4-e7867e67977a@linux.dev> (raw)
In-Reply-To: <CAA8EJpr1vWVeGsoph9h=PPQRPKkjk+d7WVQpGwpPuhCQwkqCbg@mail.gmail.com>
Hi,
On 2024/4/24 16:39, Dmitry Baryshkov wrote:
> Ok, what is the_bug_ that is being fixed by this patch?
I didn't have a way to use that driver under non DT environment,
this is the bug. Note: I demanding full features.
Both st7735r.c and repaper.c requires additional device property.
- For st7735r.c: device_property_read_u32(dev, "rotation", &rotation);
- For repaper.c: device_property_read_string(dev, "pervasive,thermal-zone", &thermal_zone)
Under non DT environment, those device properties can not be read.
Software node backend provided a way. Otherwise, the net results
of the patch doesn't meet the description in the commit message.
> If you check
> the 'submitting-patches.rst', you'll find this phrase as a description
> of the Fixes: tag.
I have readthe 'submitting-patches.rst', the first sentence tell us that
"A Fixes: tag indicates that the patch fixes an issue in a previous commit."
So what's the problem?
>>>> Hence, before my patch is applied, the two "Make driver OF-independent" patch
>>>> have no effect. Using device_get_match_data() itself is exactly*same* with
>>>> using of_device_get_match_data() as long as the .device_get_match_data hook is
>>>> not implemented.
> As far as I can see, repaper correctly handles the case by falling
> back to the spi_id. So does st7735r.c.
Yeah, this explicitly is the issue.
Falling back to other means is robust design, but it explicitly says
that the freshly addeddevice_get_match_data() don't works at all
under non DT environment. This is the bug, so what's you concern?
According to the commit message, the purpose of the introduction of
thedevice_get_match_data() is to achieve OF independent. But as you said,
it will fall back, then how does the goal "Make driver
OF-independent" can be achieved by the patch itself?
--
Best regards,
Sui
next prev parent reply other threads:[~2024-04-24 10:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 16:46 [PATCH v2] software node: Implement device_get_match_data fwnode callback Sui Jingfeng
2024-04-23 13:28 ` Andy Shevchenko
2024-04-23 16:49 ` Sui Jingfeng
2024-04-23 21:37 ` Dmitry Baryshkov
2024-04-24 5:09 ` Sui Jingfeng
2024-04-24 8:39 ` Dmitry Baryshkov
2024-04-24 10:51 ` Sui Jingfeng [this message]
2024-04-24 12:21 ` Sui Jingfeng
2024-04-24 13:10 ` Andy Shevchenko
2024-04-24 13:34 ` Dmitry Baryshkov
2024-04-24 14:52 ` Andy Shevchenko
2024-04-24 16:34 ` Dmitry Baryshkov
2024-04-24 16:44 ` Andy Shevchenko
2024-04-24 19:32 ` Dmitry Baryshkov
2024-04-25 13:42 ` Sui Jingfeng
2024-04-25 13:49 ` Andy Shevchenko
2024-04-24 18:19 ` Sui Jingfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=365445ed-8f1d-4c05-90a4-e7867e67977a@linux.dev \
--to=sui.jingfeng@linux.dev \
--cc=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).