From: "Heiko Stübner" <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Michael Riesch <michael.riesch@wolfvision.net>
Cc: Rob Herring <robh+dt@kernel.org>, Liang Chen <cl@rock-chips.com>,
Peter Geis <pgwipeout@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Simon Xue <xxm@rock-chips.com>,
Jianqun Xu <jay.xu@rock-chips.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Lee Jones <lee.jones@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Zhang Changzhong <zhangchangzhong@huawei.com>
Subject: Re: [PATCH v2 7/7] arm64: dts: rockchip: rk3568-evb1-v10: add node for sd card
Date: Wed, 04 Aug 2021 20:57:19 +0200 [thread overview]
Message-ID: <36612273.XM6RcZxFsP@diego> (raw)
In-Reply-To: <68c6c548-ff07-da79-f75c-afb6a9846932@wolfvision.net>
Hi Michael,
Am Mittwoch, 4. August 2021, 20:49:45 CEST schrieb Michael Riesch:
> Hi Johan,
>
> Thanks for your comments, I'll try to implement the requested changes
> and prepare a v3 tomorrow.
>
> On 8/4/21 4:30 PM, Johan Jonker wrote:
> > Hi Michael,
> >
> > Could you add a commit message to all patches in this serie?
>
> Well the short commit message (i.e., the subject line) pretty much wraps
> it all up in my opinion, hence no need for an extended commit message.
> Is there anything in particular you would like to see or have explained
> that requires an extended message? I would like to refrain from adding
> an extended commit message just for the sake of having one.
it's just a matter of style, and yes having a non-empty commit message
is preferred in most parts of the kernel.
Even if it's just a simple one-liner ;-), for example
"Enable the sdmmc node on the rk3568-evb1 with the 4 lanes connected on it"
Heiko
>
> > On 8/4/21 3:06 PM, Michael Riesch wrote:
> >> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> >> ---
> >> v2:
> >> - rename alias to match convention
> >>
> >> arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts | 15 +++++++++++++++
> >> 1 file changed, 15 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
> >> index ed96f27c64a3..c4da6436059d 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts
> >> @@ -17,6 +17,7 @@
> >> ethernet0 = &gmac0;
> >> ethernet1 = &gmac1;
> >
> >> mmc0 = &sdhci;
> >> + mmc1 = &sdmmc0;
> >
> > mmc aliases are sort on reg address based on availability without number
> > gap.
> >
> > sdmmc0: mmc@fe2b0000 {}
> > sdhci: mmc@fe310000 {}
>
> I'll turn these around.
>
> >> };
> >>
> >> chosen: chosen {
> >> @@ -353,6 +354,20 @@
> >> status = "okay";
> >> };
> >>
> >> +&sdmmc0 {
> >> + bus-width = <4>;
> >> + cap-sd-highspeed;
> >> + cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
> >> + disable-wp;
> >
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
> >
> > pinctrl-names below pinctrl-0 like the rest of rk356x.dtsi
>
> OK!
>
> >> + sd-uhs-sdr104;
> >
> >> + supports-sd;
> >
> > Check mmc-controller.yaml, rockchip-dw-mshc.yaml and
> > synopsys-dw-mshc-common.yaml for properties.
>
> I am afraid I don't quite follow. What exactly should I check? I am
> pretty sure that the properties I used are described in the mentioned
> yaml files.
>
> Regards, Michael
>
> >
> >> + vmmc-supply = <&vcc3v3_sd>;
> >> + vqmmc-supply = <&vccio_sd>;
> >> + status = "okay";
> >> +};
> >> +
> >> &uart2 {
> >> status = "okay";
> >> };
> >>
>
prev parent reply other threads:[~2021-08-04 18:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 13:06 [PATCH v2 0/7] arm64: dts: rockchip: rk3568-evb1-v10: add sd card support Michael Riesch
2021-08-04 13:06 ` [PATCH v2 1/7] soc: rockchip: io-domain: add rk3568 support Michael Riesch
2021-08-04 13:06 ` [PATCH v2 2/7] dt-bindings: power: add rk3568-pmu-io-domain support Michael Riesch
2021-08-04 13:06 ` [PATCH v2 3/7] arm64: dts: rockchip: rk3568-evb1-v10: add regulators of rk809 pmic Michael Riesch
2021-08-04 14:41 ` Johan Jonker
2021-08-04 13:06 ` [PATCH v2 4/7] arm64: dts: rockchip: enable io domains for rk356x Michael Riesch
2021-08-04 15:05 ` Johan Jonker
2021-08-04 13:06 ` [PATCH v2 5/7] arm64: dts: rockchip: rk3568-evb1-v10: enable io domains Michael Riesch
2021-08-04 13:06 ` [PATCH v2 6/7] arm64: dts: rockchip: rk3568-evb1-v10: add pinctrl and alias to emmc node Michael Riesch
2021-08-04 13:06 ` [PATCH v2 7/7] arm64: dts: rockchip: rk3568-evb1-v10: add node for sd card Michael Riesch
2021-08-04 14:30 ` Johan Jonker
2021-08-04 18:49 ` Michael Riesch
2021-08-04 18:57 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36612273.XM6RcZxFsP@diego \
--to=heiko@sntech.de \
--cc=cl@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=jay.xu@rock-chips.com \
--cc=jbx6244@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=xxm@rock-chips.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).