From: David Hildenbrand <david@redhat.com>
To: Souptick Joarder <jrdr.linux@gmail.com>,
kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, sashal@kernel.org,
boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, akpm@linux-foundation.org,
osalvador@suse.com, mhocko@suse.com, pasha.tatashin@soleen.com,
dan.j.williams@intel.com, richard.weiyang@gmail.com, cai@lca.pw
Cc: linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm/memory_hotplug.c: Remove __online_page_set_limits()
Date: Mon, 9 Sep 2019 09:54:37 +0200 [thread overview]
Message-ID: <36e4a98c-29da-9319-ccb1-a90f378250c6@redhat.com> (raw)
In-Reply-To: <9afe6c5a18158f3884a6b302ac2c772f3da49ccc.1567889743.git.jrdr.linux@gmail.com>
On 07.09.19 23:47, Souptick Joarder wrote:
> As both the callers of this dummy __online_page_set_limits()
> is removed, this can be removed permanently.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> include/linux/memory_hotplug.h | 1 -
> mm/memory_hotplug.c | 5 -----
> 2 files changed, 6 deletions(-)
>
> diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h
> index f46ea71..8ee3a2a 100644
> --- a/include/linux/memory_hotplug.h
> +++ b/include/linux/memory_hotplug.h
> @@ -105,7 +105,6 @@ extern unsigned long __offline_isolated_pages(unsigned long start_pfn,
> extern int set_online_page_callback(online_page_callback_t callback);
> extern int restore_online_page_callback(online_page_callback_t callback);
>
> -extern void __online_page_set_limits(struct page *page);
> extern void __online_page_increment_counters(struct page *page);
> extern void __online_page_free(struct page *page);
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index c73f099..dc0118f 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -604,11 +604,6 @@ int restore_online_page_callback(online_page_callback_t callback)
> }
> EXPORT_SYMBOL_GPL(restore_online_page_callback);
>
> -void __online_page_set_limits(struct page *page)
> -{
> -}
> -EXPORT_SYMBOL_GPL(__online_page_set_limits);
> -
> void __online_page_increment_counters(struct page *page)
> {
> adjust_managed_page_count(page, 1);
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-09-09 7:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 21:47 [PATCH 0/3] Remove __online_page_set_limits() Souptick Joarder
2019-09-07 21:47 ` [PATCH 1/3] hv_ballon: Avoid calling dummy function __online_page_set_limits() Souptick Joarder
2019-09-09 7:54 ` David Hildenbrand
2019-09-07 21:47 ` [PATCH 2/3] xen/ballon: " Souptick Joarder
2019-09-08 5:09 ` Juergen Gross
2019-09-09 7:54 ` David Hildenbrand
2019-09-07 21:47 ` [PATCH 3/3] mm/memory_hotplug.c: Remove __online_page_set_limits() Souptick Joarder
2019-09-09 7:54 ` David Hildenbrand [this message]
2019-09-09 8:12 ` [PATCH 0/3] " Michal Hocko
2019-09-09 15:42 ` Kirill A. Shutemov
2019-09-10 12:56 ` Souptick Joarder
2019-09-10 12:58 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36e4a98c-29da-9319-ccb1-a90f378250c6@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=cai@lca.pw \
--cc=dan.j.williams@intel.com \
--cc=haiyangz@microsoft.com \
--cc=jgross@suse.com \
--cc=jrdr.linux@gmail.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=richard.weiyang@gmail.com \
--cc=sashal@kernel.org \
--cc=sstabellini@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).