From: Javier Gonzalez <javier@cnexlabs.com>
To: "Matias Bjørling" <mb@lightnvm.io>
Cc: "Konopko, Igor J" <igor.j.konopko@intel.com>,
"marcin.dziegielewski@intel.com" <marcin.dziegielewski@intel.com>,
Hans Holmberg <hans.holmberg@cnexlabs.com>,
Heiner Litz <hlitz@ucsc.edu>,
Young Tack Tack Jin <youngtack.jin@circuitblvd.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lightnvm: pblk: refactor put line fn on read completion
Date: Mon, 20 Aug 2018 11:49:16 +0000 [thread overview]
Message-ID: <3799720A-6EEC-44BC-A29E-5082659B9F39@cnexlabs.com> (raw)
In-Reply-To: <20180820114320.3764-1-mb@lightnvm.io>
[-- Attachment #1: Type: text/plain, Size: 2303 bytes --]
> On 20 Aug 2018, at 13.43, Matias Bjørling <mb@lightnvm.io> wrote:
>
> The read completion path uses the put_line variable to decide whether
> the reference on a line should be released. The function name used for
> that is pblk_read_put_rqd_kref, which could lead one to believe that it
> is the rqd that is releasing the reference, while it is the line
> reference that is put.
>
> Rename and also split the function in two to account for either rqd or
> single ppa callers.
>
> Signed-off-by: Matias Bjørling <mb@lightnvm.io>
> ---
> drivers/lightnvm/pblk-read.c | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/lightnvm/pblk-read.c b/drivers/lightnvm/pblk-read.c
> index cd2f61eed6a0..16858eaf694a 100644
> --- a/drivers/lightnvm/pblk-read.c
> +++ b/drivers/lightnvm/pblk-read.c
> @@ -165,20 +165,23 @@ static void pblk_read_check_rand(struct pblk *pblk, struct nvm_rq *rqd,
> WARN_ONCE(j != rqd->nr_ppas, "pblk: corrupted random request\n");
> }
>
> -static void pblk_read_put_rqd_kref(struct pblk *pblk, struct nvm_rq *rqd)
> +static void __pblk_read_put_line(struct pblk *pblk, struct ppa_addr ppa)
> {
> - struct ppa_addr *ppa_list;
> - int i;
> -
> - ppa_list = (rqd->nr_ppas > 1) ? rqd->ppa_list : &rqd->ppa_addr;
> -
> - for (i = 0; i < rqd->nr_ppas; i++) {
> - struct ppa_addr ppa = ppa_list[i];
> struct pblk_line *line;
>
> line = &pblk->lines[pblk_ppa_to_line(ppa)];
> kref_put(&line->ref, pblk_line_put_wq);
> - }
> +}
> +
> +static void pblk_read_put_line(struct pblk *pblk, struct nvm_rq *rqd)
> +{
> + struct ppa_addr *ppa_list;
> + int i;
> +
> + ppa_list = (rqd->nr_ppas > 1) ? rqd->ppa_list : &rqd->ppa_addr;
> +
> + for (i = 0; i < rqd->nr_ppas; i++)
> + __pblk_read_put_line(pblk, ppa_list[i]);
> }
>
> static void pblk_end_user_read(struct bio *bio)
> @@ -208,7 +211,7 @@ static void __pblk_end_io_read(struct pblk *pblk, struct nvm_rq *rqd,
> bio_put(int_bio);
>
> if (put_line)
> - pblk_read_put_rqd_kref(pblk, rqd);
> + pblk_read_put_line(pblk, rqd);
>
> #ifdef CONFIG_NVM_PBLK_DEBUG
> atomic_long_add(rqd->nr_ppas, &pblk->sync_reads);
> --
> 2.11.0
Looks good to me
Reviewed-by: Javier González <javier@cnexlabs.com>
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-08-20 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 11:43 [PATCH] lightnvm: pblk: refactor put line fn on read completion Matias Bjørling
2018-08-20 11:49 ` Javier Gonzalez [this message]
[not found] ` <CAJbgVnWe0b03gvO2815rGeB=J4NOEst9FSPf_vyJ3iUSgBuQnw@mail.gmail.com>
2018-08-20 12:27 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3799720A-6EEC-44BC-A29E-5082659B9F39@cnexlabs.com \
--to=javier@cnexlabs.com \
--cc=hans.holmberg@cnexlabs.com \
--cc=hlitz@ucsc.edu \
--cc=igor.j.konopko@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.dziegielewski@intel.com \
--cc=mb@lightnvm.io \
--cc=youngtack.jin@circuitblvd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).