From: Wei Ni <wni@nvidia.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: <thierry.reding@gmail.com>, <daniel.lezcano@linaro.org>,
<linux-tegra@vger.kernel.org>, <rui.zhang@intel.com>,
<srikars@nvidia.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/3] thermal: tegra: remove unnecessary warnings
Date: Fri, 30 Nov 2018 10:52:42 +0800 [thread overview]
Message-ID: <380eb5fc-ed94-db87-9118-2fa8133d9c78@nvidia.com> (raw)
In-Reply-To: <20181129163938.GA2045@localhost.localdomain>
On 30/11/2018 12:39 AM, Eduardo Valentin wrote:
> Hey,
>
> On Thu, Nov 29, 2018 at 06:09:41PM +0800, Wei Ni wrote:
>> Convert warnings to info as not all platforms may
>> have all the thresholds and sensors enabled.
>>
>> Signed-off-by: Wei Ni <wni@nvidia.com>
>> ---
>> drivers/thermal/tegra/soctherm.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
>> index ed28110a3535..55cc1f2f6a45 100644
>> --- a/drivers/thermal/tegra/soctherm.c
>> +++ b/drivers/thermal/tegra/soctherm.c
>> @@ -550,7 +550,7 @@ static int tegra_soctherm_set_hwtrips(struct device *dev,
>>
>> ret = tz->ops->get_crit_temp(tz, &temperature);
>> if (ret) {
>> - dev_warn(dev, "thermtrip: %s: missing critical temperature\n",
>> + dev_info(dev, "thermtrip: %s: missing critical temperature\n",
>
> I am mostly ok with your change in direction. But are you sure this is a
> good thing? What about in the case that you have a platform that have
> the crit temp and you really failed to .get_crit_temp()?
If we set the crit temp in DT, but failed to .get_crit_temp(), it mean
the thermal framework have some problems. Since the critical trip is
very important, may be we should still keep "dev_warn" in here?
>
>> sg->name);
>> goto set_throttle;
>> }
>> @@ -569,7 +569,7 @@ static int tegra_soctherm_set_hwtrips(struct device *dev,
>> set_throttle:
>> ret = get_hot_temp(tz, &trip, &temperature);
>> if (ret) {
>> - dev_warn(dev, "throttrip: %s: missing hot temperature\n",
>> + dev_info(dev, "throttrip: %s: missing hot temperature\n",
>> sg->name);
>> return 0;
>> }
>> @@ -600,7 +600,7 @@ static int tegra_soctherm_set_hwtrips(struct device *dev,
>> }
>>
>> if (i == THROTTLE_SIZE)
>> - dev_warn(dev, "throttrip: %s: missing throttle cdev\n",
>> + dev_info(dev, "throttrip: %s: missing throttle cdev\n",
>> sg->name);
>>
>> return 0;
>> --
>> 2.7.4
>>
next prev parent reply other threads:[~2018-11-30 2:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 10:09 [PATCH v4 0/3] Fixes for Tegra soctherm Wei Ni
2018-11-29 10:09 ` [PATCH v4 1/3] thermal: tegra: remove unnecessary warnings Wei Ni
2018-11-29 16:39 ` Eduardo Valentin
2018-11-30 2:52 ` Wei Ni [this message]
2018-11-29 10:09 ` [PATCH v4 2/3] thermal: tegra: fix memory allocation Wei Ni
2018-11-29 10:09 ` [PATCH v4 3/3] thermal: tegra: parse sensor id before sensor register Wei Ni
2018-11-29 16:46 ` Eduardo Valentin
2018-11-30 3:00 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=380eb5fc-ed94-db87-9118-2fa8133d9c78@nvidia.com \
--to=wni@nvidia.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srikars@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).