From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 996BBC56201 for ; Tue, 24 Nov 2020 10:56:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3980C2076E for ; Tue, 24 Nov 2020 10:56:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ozlabs-ru.20150623.gappssmtp.com header.i=@ozlabs-ru.20150623.gappssmtp.com header.b="SSOV3AHK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732322AbgKXK4q (ORCPT ); Tue, 24 Nov 2020 05:56:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbgKXK4q (ORCPT ); Tue, 24 Nov 2020 05:56:46 -0500 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B76B5C0617A6 for ; Tue, 24 Nov 2020 02:56:44 -0800 (PST) Received: by mail-pg1-x542.google.com with SMTP id j19so17122072pgg.5 for ; Tue, 24 Nov 2020 02:56:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ozlabs-ru.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ho+OU1gWIbxlU6vkFFYhPItLBY/4CgC1Ux1l0SznRAg=; b=SSOV3AHKcYwB6+VVY1RKwf3eonAoK6VB7pgCtKHR8LD3fRuhXLehOkIUQSnbQIDI4/ p3q0lllVhyARw/nFniVJuSZDSA1nyuupwNNDJFfBpDHPMhOE1FaqJl/r4F+EjejdwGh6 JcTYJjpYmkK5vvITW2a+tZh4AjKcXiOtBFjVSdkurRhJSjv91DLg2qu+cCdrKbmCH2ek XlPQWnIeN1dG8UEFO7U6FU5ocZw0syYsyS7a7xM2lRPAMw13hOx8/vzLXyLbY8/o4EiN 9GUnx1vWcyBeLGNll61sm78qt98gQpFgpeGDJx/kqBx4w5ovOS0zJDPQfVVMkvsWOSLZ 1UcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ho+OU1gWIbxlU6vkFFYhPItLBY/4CgC1Ux1l0SznRAg=; b=jm+2LVAr3qB0nlRiRGuhhaLWxCqJTWoTwRkPNqRxOTZ/Tl3EP181ZnHCyISFnCxQhC CqNI0fsfLCbwVoqVqiWCtC3rEcVl/7Zf312kB/WZCtMJJS1+3zxdrMItM5JgAt9+M0Qz 92BfSIu+W4U1D1I0iOSNKCqJFWkYDbV0ylbxpD8wu0HBqCdvN+H+DoJzm7C+sooSv+7e jmTM7mQCgwJHugxqzxbG/+JZWz7wQAkk6Y6imhhlKECaUSjQZ/9EZxRdF2EN7QudTWSO e/pxv3+mE/3jSoLxINDDLcL41XjRpGJOCl+YMWsRdd5oIzB+Eo6STKiIi+2SRqCu1X5t 2ahg== X-Gm-Message-State: AOAM533DCk1TN56zJCcPZm2y1dbmeKYDB1Su+CATChSN9e8TEeaSXyJD n/wye7O/3WE2YOhNExY0wtvzwQ== X-Google-Smtp-Source: ABdhPJx7aupXyGjbsXOlPp/GgIVXYWhXASJLws7GvUy6w0exJM/+0lrVY6h+M0ix3HjuU4jTiROcvg== X-Received: by 2002:a17:90b:4398:: with SMTP id in24mr4069757pjb.188.1606215404113; Tue, 24 Nov 2020 02:56:44 -0800 (PST) Received: from [0.0.0.0] (124-171-134-245.dyn.iinet.net.au. [124.171.134.245]) by smtp.gmail.com with UTF8SMTPSA id j10sm1087588pji.29.2020.11.24.02.56.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Nov 2020 02:56:43 -0800 (PST) Subject: Re: [PATCH kernel v4 2/8] genirq/irqdomain: Clean legacy IRQ allocation To: Andy Shevchenko Cc: Linux Kernel Mailing List , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Frederic Barrat , =?UTF-8?Q?Michal_Such=c3=a1nek?= , Oliver O'Halloran , Marc Zyngier , Thomas Gleixner , linux-arm Mailing List , "open list:GPIO SUBSYSTEM" , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" References: <20201124061720.86766-1-aik@ozlabs.ru> <20201124061720.86766-3-aik@ozlabs.ru> From: Alexey Kardashevskiy Message-ID: <38b803db-2d67-dfa0-7e7b-e4ce816576ad@ozlabs.ru> Date: Tue, 24 Nov 2020 21:56:36 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/24/20 8:19 PM, Andy Shevchenko wrote: > On Tue, Nov 24, 2020 at 8:20 AM Alexey Kardashevskiy wrote: >> >> There are 10 users of __irq_domain_alloc_irqs() and only one - IOAPIC - >> passes realloc==true. There is no obvious reason for handling this >> specific case in the generic code. >> >> This splits out __irq_domain_alloc_irqs_data() to make it clear what >> IOAPIC does and makes __irq_domain_alloc_irqs() cleaner. >> >> This should cause no behavioral change. > >> + ret = __irq_domain_alloc_irqs_data(domain, virq, nr_irqs, node, arg, affinity); >> + if (ret <= 0) >> goto out_free_desc; > > Was or wasn't 0 considered as error code previously? Oh. I need to clean this up, the idea is since this does not allocate IRQs, this should return error code and not an irq, I'll make this explicit. > >> return virq; > >> out_free_desc: >> irq_free_descs(virq, nr_irqs); >> return ret; > -- Alexey