From: Michael Walle <michael@walle.cc>
To: Rob Herring <robh@kernel.org>
Cc: Robert Marko <robert.marko@sartura.hr>,
lee.jones@linaro.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, jdelvare@suse.com, linux@roeck-us.net,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org,
luka.perkov@sartura.hr, jmp@epiphyte.org, pmenzel@molgen.mpg.de,
buczek@molgen.mpg.de
Subject: Re: [PATCH 3/6] gpio: Add Delta TN48M CPLD GPIO driver
Date: Thu, 06 May 2021 18:40:37 +0200 [thread overview]
Message-ID: <3905879e67d50d6a7f73fcd83982c052@walle.cc> (raw)
In-Reply-To: <20210506140024.GB3340759@robh.at.kernel.org>
Am 2021-05-06 16:00, schrieb Rob Herring:
> On Fri, Apr 30, 2021 at 02:35:08PM +0200, Robert Marko wrote:
>> Delta TN48M CPLD is used as a GPIO expander for the SFP GPIOs.
>>
>> It is a mix of input only and output only pins.
>>
>> Since there is no logical GPIO numbering arbitrary one is used
>> along dt-bindings to make it humanly readable.
>>
>> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
>> ---
>> drivers/gpio/Kconfig | 12 +++
>> drivers/gpio/Makefile | 1 +
>> drivers/gpio/gpio-tn48m.c | 191
>> ++++++++++++++++++++++++++++++++++++++
>> drivers/mfd/tn48m-cpld.c | 6 +-
>> include/linux/mfd/tn48m.h | 3 +
>> 5 files changed, 212 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/gpio/gpio-tn48m.c
>
>
>> +static const struct platform_device_id tn48m_gpio_id_table[] = {
>> + { "delta,tn48m-gpio", },
>
> Looks like a compatible, but is not. I think you can drop this and just
> use 'tm48m-gpio' (the driver name).
I'm just curious, why isn't the vendor included here (as there
might be a chance for name clashes in the future).
-michael
next prev parent reply other threads:[~2021-05-06 16:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 12:35 [PATCH 1/6] mfd: Add Delta TN48M CPLD driver Robert Marko
2021-04-30 12:35 ` [PATCH 2/6] dt-bindings: gpio: Add Delta TN48M CPLD GPIO bindings Robert Marko
2021-05-06 13:57 ` Rob Herring
2021-04-30 12:35 ` [PATCH 3/6] gpio: Add Delta TN48M CPLD GPIO driver Robert Marko
2021-05-06 14:00 ` Rob Herring
2021-05-06 16:40 ` Michael Walle [this message]
2021-05-06 17:21 ` Luka Perkov
2021-05-21 13:22 ` Robert Marko
2021-05-06 16:38 ` Michael Walle
2021-05-21 13:21 ` Robert Marko
2021-04-30 12:35 ` [PATCH 4/6] hwmon: Add Delta TN48M CPLD HWMON driver Robert Marko
2021-04-30 13:12 ` Guenter Roeck
2021-05-19 12:01 ` Robert Marko
2021-05-19 13:40 ` Guenter Roeck
2021-04-30 12:35 ` [PATCH 5/6] dt-bindings: mfd: Add Delta TN48M CPLD drivers bindings Robert Marko
2021-05-06 14:01 ` Rob Herring
2021-04-30 12:35 ` [PATCH 6/6] MAINTAINERS: Add Delta Networks TN48M CPLD drivers Robert Marko
2021-05-06 16:34 ` [PATCH 1/6] mfd: Add Delta TN48M CPLD driver Michael Walle
2021-05-19 11:53 ` Robert Marko
2021-05-19 19:42 ` Michael Walle
2021-05-20 6:49 ` Lee Jones
2021-05-21 8:19 ` Robert Marko
2021-05-21 9:03 ` Lee Jones
2021-05-21 9:06 ` Robert Marko
2021-05-06 16:50 ` kernel test robot
2021-05-19 11:11 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3905879e67d50d6a7f73fcd83982c052@walle.cc \
--to=michael@walle.cc \
--cc=bgolaszewski@baylibre.com \
--cc=buczek@molgen.mpg.de \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=jmp@epiphyte.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luka.perkov@sartura.hr \
--cc=pmenzel@molgen.mpg.de \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).