From: Joe Perches <joe@perches.com>
To: Carlos Bilbao <bilbao@vt.edu>, James.Bottomley@hansenpartnership.com
Cc: deller@gmx.de, linux-parisc@vger.kernel.org,
linux-kernel@vger.kernel.org, andrew@lunn.ch
Subject: Re: [PATCH] drivers: parisc: Follow the indentation coding standard on printks
Date: Thu, 08 Jul 2021 09:46:54 -0700 [thread overview]
Message-ID: <39a7b7c455c6c23f0bfe7403b4957d2c92196d46.camel@perches.com> (raw)
In-Reply-To: <1793924.CQOukoFCf9@iron-maiden>
On Thu, 2021-07-08 at 11:25 -0400, Carlos Bilbao wrote:
> Fix indentation of printks that start at the beginning of the line. Change this
> for the right number of space characters, or tabs if the file uses them.
These are ancient codes, but:
> diff --git a/drivers/parisc/iosapic.c b/drivers/parisc/iosapic.c
[]
> @@ -633,7 +633,7 @@ static void iosapic_unmask_irq(struct irq_data *d)
> printk("\n");
> }
>
>
> -printk("iosapic_enable_irq(): sel ");
> + printk("iosapic_enable_irq(): sel ");
> {
> struct iosapic_info *isp = vi->iosapic;
>
>
> @@ -642,7 +642,7 @@ printk("iosapic_enable_irq(): sel ");
> printk(" %x", d1);
> }
> }
> -printk("\n");
> + printk("\n");
> #endif
This is in an undefined #ifdef block and the block could be deleted.
> diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c
[]
> @@ -1550,7 +1550,7 @@ static void sba_hw_init(struct sba_device *sba_dev)
>
>
>
>
> #if 0
#if 0 blocks can be removed.
> -printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x 0x%x\n", PAGE0->mem_boot.hpa,
> + printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x 0x%x\n", PAGE0->mem_boot.hpa,
> PAGE0->mem_boot.spa, PAGE0->mem_boot.pad, PAGE0->mem_boot.cl_class);
>
>
> /*
next prev parent reply other threads:[~2021-07-08 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 15:25 [PATCH] drivers: parisc: Follow the indentation coding standard on printks Carlos Bilbao
2021-07-08 16:46 ` Joe Perches [this message]
2021-07-08 17:40 ` [PATCH net-next v2] drivers: parisc: Remove unnecessary #if blocks Carlos Bilbao
2021-07-08 18:04 ` Andrew Lunn
2021-07-08 18:13 ` bilbao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39a7b7c455c6c23f0bfe7403b4957d2c92196d46.camel@perches.com \
--to=joe@perches.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andrew@lunn.ch \
--cc=bilbao@vt.edu \
--cc=deller@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).