From: Shailabh Nagar <nagar@watson.ibm.com>
To: Ben LaHaise <bcrl@redhat.com>
Cc: Andrew Morton <akpm@digeo.com>,
Alexander Viro <viro@math.psu.edu>,
linux-aio <linux-aio@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
lse-tech <lse-tech@lists.sourceforge.net>
Subject: [RFC] adding aio_readv/writev
Date: Fri, 20 Sep 2002 16:39:40 -0400 [thread overview]
Message-ID: <3D8B878C.8070503@watson.ibm.com> (raw)
Ben,
Currently there is no way to initiate an aio readv/writev in 2.5. There
were no aio_readv/writev calls in 2.4 either - I'm wondering if there
was any particular reason for excluding readv/writev operations from aio ?
The read/readv paths have anyway been merged for raw/O_DIRECT and
regular file read/writes. So why not expose the vector read/write to the
user by adding the IOCB_CMD_PREADV/IOCB_CMD_READV and
IOCB_CMD_PWRITEV/IOCB_CMD_WRITEV commands to the aio set. Without that,
raw/O_DIRECT readv users would need to unnecessarily cycle through their
iovecs at a library level submitting them individually.
For larger iovecs, user/library code would needlessly deal with multiple
completions. While I'm not sure of the performance impact of the absence
of aio_readv/writev, it seems easy enough to provide.
Most of the functions are already in place. We would only
need a way to pass the iovec through the iocb.
I was thinking of something like this:
struct iocb {
+union {
__u64 aio_buf
+ __u64 aio_iovp
+}
+union {
__u64 aio_nbytes
+ __u64 aio_nsegs
+}
allowing the iovec * & nsegs to be passed into sys_io_submit. Some code
would be added (within case handling of IOCB_CMD_READV within
io_submit_one) to copy & verify the iovec pointers and then call
aio_readv/aio_writev (if its defined for the fs).
What do you think ? I wanted to get some feedback before trying to code
this up.
While we are on the topic of expanding aio operations, what about
providing IOCB_CMD_READ/WRITE, distinct from their pread/pwrite
counterparts ? Do you think thats needed ?
- Shailabh
next reply other threads:[~2002-09-20 20:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-20 20:39 Shailabh Nagar [this message]
[not found] ` <1032555981.2082.10.camel@dell_ss3.pdx.osdl.net>
2002-09-23 14:30 ` [RFC] adding aio_readv/writev Shailabh Nagar
2002-09-23 18:53 ` Clement T. Cole
[not found] ` <20020923114104.A11680@redhat.com>
2002-09-24 13:20 ` John Gardiner Myers
2002-09-24 13:52 ` Stephen C. Tweedie
2002-09-24 14:13 ` John Gardiner Myers
2002-09-23 17:59 Chen, Kenneth W
[not found] <200209231851.g8NIpea12782@igw2.watson.ibm.com>
2002-09-23 19:52 ` Shailabh Nagar
2002-09-23 20:39 ` Clement T. Cole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D8B878C.8070503@watson.ibm.com \
--to=nagar@watson.ibm.com \
--cc=akpm@digeo.com \
--cc=bcrl@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).