linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Piggin <piggin@cyberone.com.au>
To: Jens Axboe <axboe@suse.de>
Cc: Zwane Mwaikambo <zwane@linuxpower.ca>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Badness in as-iosched:1210
Date: Fri, 25 Apr 2003 18:28:28 +1000	[thread overview]
Message-ID: <3EA8F1AC.4080509@cyberone.com.au> (raw)
In-Reply-To: <20030425062329.GB1012@suse.de>

Jens Axboe wrote:

>On Fri, Apr 25 2003, Nick Piggin wrote:
>
>>Jens Axboe wrote:
>>
>>
>>>On Fri, Apr 25 2003, Nick Piggin wrote:
>>>
>>>Exactly, the rest looks ok, the debug trigger is wrong :). The
>>>add_request() strategy is the entry point for all types of requests, not
>>>just blk_fs_request()
>>>
>>>
>>No but it is as_insert_request which is that entry point. It
>>should only calls as_add_request for a blk_fs_request.
>>
>
>Oh I see, yes you are right, I should have looked closer (I just assumed
>it was your elevator_add_req_fn, your naming is a bit funny :)
>
>The debug check is still a bit silly, and there's nothing that stops it
>from being wrong. So I'd still suggest to kill it.
>
Well the debug check is supposed to catch drivers which aren't
behaving nicely or if the reference counting is broken somewhere.

I suppose now that blk_put_request is being used to call
elv_completed_request then it should be pretty safe, right?

So I'll remove the debug stuff then


      reply	other threads:[~2003-04-25  8:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-23  3:04 Badness in as-iosched:1210 Zwane Mwaikambo
2003-04-24  8:31 ` Nick Piggin
2003-04-24  8:47   ` Jens Axboe
2003-04-24 17:09     ` Nick Piggin
2003-04-24 17:32       ` Jens Axboe
2003-04-25  3:04         ` Nick Piggin
2003-04-25  6:23           ` Jens Axboe
2003-04-25  8:28             ` Nick Piggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3EA8F1AC.4080509@cyberone.com.au \
    --to=piggin@cyberone.com.au \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zwane@linuxpower.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).